Bug 212838 - audio/fluidsynth: Add sndio support
Summary: audio/fluidsynth: Add sndio support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-20 05:12 UTC by Tobias Kortkamp
Modified: 2016-12-17 13:50 UTC (History)
3 users (show)

See Also:
riggs: maintainer-feedback+

Attachments
fluidsynth.diff (25.34 KB, patch)
2016-09-20 05:12 UTC, Tobias Kortkamp 		riggs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-09-20 05:12:13 UTC 
Created attachment 174983 [details]
fluidsynth.diff

This adds an option SNDIO which enables support for both audio output and MIDI input over audio/sndio to Fluidsynth.

Unfortunately Fluidsynth does not have upstream support for sndio, so the patch is relatively large.  If this is a problem I can create a separate port instead.

This is mostly sourced from the OpenBSD ports tree.  The OpenBSD port uses autoconf while the FreeBSD port has opted for cmake, so I had to add the sndio sources to the cmake build files instead.

portlint ok, Poudriere build on FreeBSD 10.3/amd64 ok
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2016-10-13 19:08:09 UTC 
fails to build on 12a, 11a with:

checking for gperf... no
configure: error: You need to install gperf <https://www.gnu.org/software/gperf/> before building.
===>  Script "configure" failed unexpectedly.
Please report the problem to pcm@pogotopia.net [maintainer] and attach the
"/wrkdirs/usr/ports/net-mgmt/naemon-core/work/naemon-core-1.0.5/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2016-10-13 19:08:29 UTC 
Sorry, wrong PR for comment #2.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-12-17 13:42:22 UTC 
A commit references this bug:

Author: riggs
Date: Sat Dec 17 13:41:33 UTC 2016
New revision: 428763
URL: https://svnweb.freebsd.org/changeset/ports/428763

Log:
  Add SNDIO support and non-default OPTION

  PR:		212838
  Submitted by:	t@tobik.me

Changes:
  head/audio/fluidsynth/Makefile
  head/audio/fluidsynth/files/fluid_sndio.c
  head/audio/fluidsynth/files/patch-CMakeLists.txt
  head/audio/fluidsynth/files/patch-cmake__admin_report.cmake
  head/audio/fluidsynth/files/patch-src_CMakeLists.txt
  head/audio/fluidsynth/files/patch-src_config.cmake
  head/audio/fluidsynth/files/patch-src_drivers_fluid__adriver.c
  head/audio/fluidsynth/files/patch-src_drivers_fluid__mdriver.c