Bug 212849 - games/osgg: Unbreak fetch, improve (v1.0)
Summary: games/osgg: Unbreak fetch, improve (v1.0)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-20 11:08 UTC by lightside
Modified: 2016-09-21 15:21 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
Proposed patch (since 422447 revision) (1.57 KB, patch)
2016-09-20 11:08 UTC, lightside
lightside: maintainer-approval? (amdmi3)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2016-09-20 11:08:15 UTC
Created attachment 174999 [details]
Proposed patch (since 422447 revision)

Patch to unbreak games/osgg and improve port.

- Unbreak fetch with using available distfile
- Adapt WRKSRC value
- Remove -f argument near ${RM} value
- Put cd related commands in parenthesis
- Regenerate distinfo file with using `make makesum` command and correct TIMESTAMP value

Note about parenthesis for cd related commands:
-8<--
man make | grep "in parenthesis" -h5 | tail -8
     Makefiles should be written so that the mode of make operation does not
     change their behavior.  For example, any command which needs to use "cd"
     or	"chdir", without side-effect should be put in parenthesis:


	   avoid-chdir-side-effects:
		   @echo Building $@ in	`pwd`
		   @(cd	${.CURDIR} && ${.MAKE} $@)
-->8-

Note about ${RM} value and -f argument:
-8<--
make -C /usr/ports -V RM
/bin/rm -f
-->8-

How TIMESTAMP value was generated (for this case):
make clean extract && find work/* -type f -print0 | xargs -0 stat -f '%m' | sort -u | tail -1 && make clean
or
make clean extract && find work/* -type f -exec stat -f '%m' {} + | sort -u | tail -1 && make clean
Comment 1 lightside 2016-09-20 11:12:18 UTC
Possible to bump PORTREVISION, but I didn't because of no available packages on PortsMon for 1.0 version:
http://portsmon.freebsd.org/portoverview.py?category=games&portname=osgg
Comment 2 Dmitry Marakasov freebsd_committer 2016-09-21 15:21:21 UTC
Committed simplified version of the port
Comment 3 commit-hook freebsd_committer 2016-09-21 15:21:42 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Sep 21 15:20:42 UTC 2016
New revision: 422565
URL: https://svnweb.freebsd.org/changeset/ports/422565

Log:
  - Unbreak fetch, switch to github, simplify port

  PR:		212849
  Submitted by:	lightside@gmx.com

Changes:
  head/games/osgg/Makefile
  head/games/osgg/distinfo
  head/games/osgg/files/