Bug 213157 - [PATCH] Fix security/cracklib dictionary path
Summary: [PATCH] Fix security/cracklib dictionary path
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-02 13:10 UTC by Florian Riehm
Modified: 2018-10-11 10:02 UTC (History)
3 users (show)

See Also:
antoine: exp-run-


Attachments
Adjust cracklib dictionary path (3.10 KB, patch)
2016-10-02 13:10 UTC, Florian Riehm
no flags Details | Diff
heimdal.diff (840 bytes, patch)
2018-10-11 09:44 UTC, Tobias Kortkamp
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Riehm 2016-10-02 13:10:04 UTC
Created attachment 175365 [details]
Adjust cracklib dictionary path

Some time ago in security/cracklib the file pw_dict moved to cracklib-words
(r408137). Now security/revelation throws warnings because it can
not find pw_dict.pwd . The attached patch fixes the problem for revelation (tested) and corrects the path for some other ports (untested).
Comment 1 Cy Schubert freebsd_committer 2016-10-02 20:31:49 UTC
Since the complete patch hasn't been tested, an exp-run is needed. Flag set.

Added maintainers of other affected ports for feedback (hrs@FreeBSD.org, perl@FreeBSD.org).
Comment 2 commit-hook freebsd_committer 2018-10-11 09:28:20 UTC
A commit references this bug:

Author: tobik
Date: Thu Oct 11 09:27:38 UTC 2018
New revision: 481799
URL: https://svnweb.freebsd.org/changeset/ports/481799

Log:
  mail/qmailadmin: Chase cracklib dictionary rename from r408137

  PR:		213157
  Submitted by:	Florian Riehm <mail@friehm.de>
  Approved by:	2 year bug anniversary

Changes:
  head/mail/qmailadmin/Makefile
  head/mail/qmailadmin/files/cracklib.patch
Comment 3 commit-hook freebsd_committer 2018-10-11 09:31:25 UTC
A commit references this bug:

Author: tobik
Date: Thu Oct 11 09:30:29 UTC 2018
New revision: 481800
URL: https://svnweb.freebsd.org/changeset/ports/481800

Log:
  security/p5-Crypt-Cracklib: Chase cracklib dictionary rename from r408137

  PR:		213157
  Submitted by:	Florian Riehm <mail@friehm.de>
  Approved by:	2 year bug anniversary

Changes:
  head/security/p5-Crypt-Cracklib/Makefile
Comment 4 commit-hook freebsd_committer 2018-10-11 09:39:35 UTC
A commit references this bug:

Author: tobik
Date: Thu Oct 11 09:38:35 UTC 2018
New revision: 481802
URL: https://svnweb.freebsd.org/changeset/ports/481802

Log:
  security/pecl-crack: Chase cracklib dictionary rename from r408137

  This also makes all tests pass.

  PR:		213157
  Submitted by:	Florian Riehm <mail@friehm.de>
  Approved by:	2 year bug anniversary

Changes:
  head/security/pecl-crack/Makefile
Comment 5 Tobias Kortkamp freebsd_committer 2018-10-11 09:44:40 UTC
Created attachment 198033 [details]
heimdal.diff

All fixed (security/revelation in ports r481611) except heimdal.
Comment 6 Tobias Kortkamp freebsd_committer 2018-10-11 09:46:45 UTC
I'm not sure if an exp-run is really needed for heimdal, but over to portmgr
for an exp-run as requested by cy@.
Comment 7 Antoine Brodin freebsd_committer 2018-10-11 09:49:38 UTC
Not enough ports depend on this for an exp-run.
Comment 8 commit-hook freebsd_committer 2018-10-11 09:56:51 UTC
A commit references this bug:

Author: tobik
Date: Thu Oct 11 09:56:41 UTC 2018
New revision: 481805
URL: https://svnweb.freebsd.org/changeset/ports/481805

Log:
  security/heimdal: Chase cracklib dictionary rename from r408137

  PR:		213157
  Submitted by:	Florian Riehm <mail@friehm.de>
  Approved by:	2 year bug anniversary

Changes:
  head/security/heimdal/Makefile
  head/security/heimdal/files/kpasswdd-cracklib.c
Comment 9 commit-hook freebsd_committer 2018-10-11 09:58:55 UTC
A commit references this bug:

Author: tobik
Date: Thu Oct 11 09:58:03 UTC 2018
New revision: 481806
URL: https://svnweb.freebsd.org/changeset/ports/481806

Log:
  MFH: r481799

  mail/qmailadmin: Chase cracklib dictionary rename from r408137

  PR:		213157
  Submitted by:	Florian Riehm <mail@friehm.de>
  Approved by:	2 year bug anniversary

  Approved by:	ports-secteam runtime fix blanket

Changes:
_U  branches/2018Q4/
  branches/2018Q4/mail/qmailadmin/Makefile
  branches/2018Q4/mail/qmailadmin/files/cracklib.patch
Comment 10 commit-hook freebsd_committer 2018-10-11 09:58:57 UTC
A commit references this bug:

Author: tobik
Date: Thu Oct 11 09:58:38 UTC 2018
New revision: 481807
URL: https://svnweb.freebsd.org/changeset/ports/481807

Log:
  MFH: r481800

  security/p5-Crypt-Cracklib: Chase cracklib dictionary rename from r408137

  PR:		213157
  Submitted by:	Florian Riehm <mail@friehm.de>
  Approved by:	2 year bug anniversary

  Approved by:	ports-secteam runtime fix blanket

Changes:
_U  branches/2018Q4/
  branches/2018Q4/security/p5-Crypt-Cracklib/Makefile
Comment 11 commit-hook freebsd_committer 2018-10-11 10:00:00 UTC
A commit references this bug:

Author: tobik
Date: Thu Oct 11 09:59:16 UTC 2018
New revision: 481808
URL: https://svnweb.freebsd.org/changeset/ports/481808

Log:
  MFH: r481802

  security/pecl-crack: Chase cracklib dictionary rename from r408137

  This also makes all tests pass.

  PR:		213157
  Submitted by:	Florian Riehm <mail@friehm.de>
  Approved by:	2 year bug anniversary

  Approved by:	ports-secteam runtime fix blanket

Changes:
_U  branches/2018Q4/
  branches/2018Q4/security/pecl-crack/Makefile
Comment 12 commit-hook freebsd_committer 2018-10-11 10:01:04 UTC
A commit references this bug:

Author: tobik
Date: Thu Oct 11 09:59:57 UTC 2018
New revision: 481809
URL: https://svnweb.freebsd.org/changeset/ports/481809

Log:
  MFH: r481805

  security/heimdal: Chase cracklib dictionary rename from r408137

  PR:		213157
  Submitted by:	Florian Riehm <mail@friehm.de>
  Approved by:	2 year bug anniversary

  Approved by:	ports-secteam runtime fix blanket

Changes:
_U  branches/2018Q4/
  branches/2018Q4/security/heimdal/Makefile
  branches/2018Q4/security/heimdal/files/kpasswdd-cracklib.c
Comment 13 Tobias Kortkamp freebsd_committer 2018-10-11 10:02:06 UTC
(In reply to Antoine Brodin from comment #7)
Thanks for clarifying, Antoine.

(In reply to Florian Riehm from comment #0)
Thank you for the report and apologies that it took us 2 years to fix this...