Bug 213191 - devel/p5-File-Remove: update to 1.57
Summary: devel/p5-File-Remove: update to 1.57
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-04 15:09 UTC by Dmitry Marakasov
Modified: 2016-10-19 18:58 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback+

Attachments
Patch (794 bytes, patch)
2016-10-04 15:09 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2016-10-04 15:09:41 UTC 
Created attachment 175415 [details]
Patch
Comment 1 Wen Heping freebsd_committer freebsd_triage 2016-10-07 02:52:25 UTC 
Build and run well, why not commit it by yourself ?

wen
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2016-10-11 15:31:37 UTC 
I thought perl@ approval is needed, is it not?
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-10-11 15:43:32 UTC 
Add yourself to

https://wiki.freebsd.org/Perl

and you can approve it 8-}
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2016-10-11 16:34:44 UTC 
(In reply to Kurt Jaeger from comment #3)
> Add yourself to
> 
> https://wiki.freebsd.org/Perl
> 
> and you can approve it 8-}

That's a strange idea. The idea of groups like perl@, python@ or whatever is so that people with enough knowledge of how things work can review patches.

What you are saying is that while not knowing much about Python, I can add myself to the python group, and then commit updates to lang/python without any review or approval.
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-10-19 18:55:59 UTC 
(In reply to Mathieu Arnold from comment #4)

This works to a certain point, but some of those teams are so that              
no member sees the urge or competence to act and approve and so PRs             
collect dust, waiting for an approval that never comes.                         
                                                                                
> What you are saying is that while not knowing much about Python, I can 
> add myself to the python group, and then commit updates to lang/python 
> without any review or approval.

What I'm saying is that Dmitry knows enough about ports that
a simple change like the one he suggested will cause no harm.
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2016-10-19 18:58:05 UTC 
Committed, thanks.
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-10-19 18:58:13 UTC 
A commit references this bug:

Author: pi
Date: Wed Oct 19 18:57:54 UTC 2016
New revision: 424283
URL: https://svnweb.freebsd.org/changeset/ports/424283

Log:
  devel/p5-File-Remove: update 1.52 -> 1.57

  PR:		213191
  Changes:	http://cpansearch.perl.org/src/SHLOMIF/File-Remove-1.57/Changes
  Submitted by:	amdmi3

Changes:
  head/devel/p5-File-Remove/Makefile
  head/devel/p5-File-Remove/distinfo