Bug 213332 - Pasted "patch" attachments are wrongly processed
Summary: Pasted "patch" attachments are wrongly processed
Status: New
Alias: None
Product: Services
Classification: Unclassified
Component: Bug Tracker (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Only Me
Assignee: Bugmeister
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2016-10-09 09:33 UTC by VK
Modified: 2016-10-09 09:44 UTC (History)
0 users

See Also:

Attachments
nss.patch (690 bytes, patch)
2016-10-09 09:34 UTC, VK 		no flags Details | Diff
nss.patch (690 bytes, patch)
2016-10-09 09:35 UTC, VK 		no flags Details | Diff
nss.patch pasted (713 bytes, patch)
2016-10-09 09:37 UTC, VK 		no flags Details | Diff
nss.patch pasted (713 bytes, text/plain)
2016-10-09 09:38 UTC, VK 		no flags Details
nss.patch pasted (copied via ssh) (781 bytes, patch)
2016-10-09 09:42 UTC, VK 		no flags Details | Diff
nss.patch pasted (copied via ssh) (781 bytes, text/plain)
2016-10-09 09:43 UTC, VK 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description VK freebsd_triage 2016-10-09 09:33:34 UTC 
It appears that attachments marked "patch", when pasted (not uploaded as a file), are wrongly processed. Test cases coming up.
Comment 1 VK freebsd_triage 2016-10-09 09:34:39 UTC 
Created attachment 175561 [details]
nss.patch

Create attachment by UPLOADING a patch file, flagging it PATCH.
Comment 2 VK freebsd_triage 2016-10-09 09:35:13 UTC 
Created attachment 175562 [details]
nss.patch

Create attachment by UPLOADING a patch file, not flagged as patch.
Comment 3 VK freebsd_triage 2016-10-09 09:37:04 UTC 
Created attachment 175563 [details]
nss.patch pasted

Create attachment by PASTING patch file contents, obtained by catting the nss.patch in Ubuntu terminal, then copying the contents.

Flagged as PATCH.
Comment 4 VK freebsd_triage 2016-10-09 09:38:04 UTC 
Created attachment 175564 [details]
nss.patch pasted

Create attachment by PASTING patch file contents, obtained by catting the nss.patch in Ubuntu terminal, then copying the contents.

NOT flagged as patch (bugzilla shows "auto-detect" for content type)
Comment 5 VK freebsd_triage 2016-10-09 09:42:26 UTC 
Created attachment 175565 [details]
nss.patch pasted (copied via ssh)

Contents PASTED, but obtained by copying the output of `svn diff security/nss` from terminal connection to the build server over ssh... Flagged as PATCH.
Comment 6 VK freebsd_triage 2016-10-09 09:43:10 UTC 
Created attachment 175566 [details]
nss.patch pasted (copied via ssh)

Contents PASTED, but obtained by copying the output of `svn diff security/nss` from terminal connection to the build server over ssh...

NOT flagged as patch.
Comment 7 VK freebsd_triage 2016-10-09 09:44:18 UTC 
So, if flagged as PATCH and copied over SSH, it's mungled:

https://bz-attachments.freebsd.org/attachment.cgi?id=175565&action=diff&format=raw&headers=1