Bug 213360 - devel/gflags: patch: Add pkgconf file
Summary: devel/gflags: patch: Add pkgconf file
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-10-10 16:33 UTC by rozhuk.im
Modified: 2016-11-26 11:13 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)
koobs: merge-quarterly?


Attachments
add libdata/pkgconfig/libgflags.pc (1.51 KB, patch)
2016-10-10 16:33 UTC, rozhuk.im
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rozhuk.im 2016-10-10 16:33:22 UTC
Created attachment 175607 [details]
add libdata/pkgconfig/libgflags.pc

Add libdata/pkgconfig/libgflags.pc after install.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-11 08:57:42 UTC
Thank you for your submission. Can you confirm that this change passes QA (portlint, poudriere) please?

Also:

- is the lack of this file currently causing issues with compilation of other ports or software? If so, this change should also be merged to the quarterly branch

- Can this be submitted upstream?
Comment 2 rozhuk.im 2016-10-11 09:38:53 UTC
I do no QA tests, only build+install on my desktop.

This only add pkgconf to help other software to find this lib and add lib/includes to project. I think this should not broke other ports.

I would be happy if this come to upstream. :)
Comment 3 Antoine Brodin freebsd_committer 2016-10-11 14:11:09 UTC
We don't do exp-run for ports that only a dozen other ports depend upon, please test yourself.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-12 09:45:46 UTC
@Antoine sorry, that was supposed to be the merge-quarterly flag ;)
Comment 5 Sunpoet Po-Chuan Hsieh freebsd_committer 2016-11-26 11:13:58 UTC
gflags was updated to 2.2.0 in r427139 which has official pkg-config support.