Bug 213375 - [patch] OptionalObsoleteFiles.inc misses NIS /etc/rc.d/yp* files
Summary: [patch] OptionalObsoleteFiles.inc misses NIS /etc/rc.d/yp* files
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: 11.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Baptiste Daroussin
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-11 11:56 UTC by Sergey Akhmatov
Modified: 2017-11-05 20:48 UTC (History)
1 user (show)

See Also:

Attachments
WITHOUT_NIS rc.d-scripts patch (481 bytes, patch)
2016-10-11 11:56 UTC, Sergey Akhmatov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Akhmatov 2016-10-11 11:56:41 UTC 
Created attachment 175617 [details]
WITHOUT_NIS rc.d-scripts patch

make delete-old doesn't delete NIS-related /etc/rc.d scripts with WITHOUT_NIS option enabled

/etc/rc.d/ypbind
/etc/rc.d/ypldap
/etc/rc.d/yppasswdd
/etc/rc.d/ypserv
/etc/rc.d/ypset
/etc/rc.d/ypupdated
/etc/rc.d/ypxfrd
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-10-22 19:52:18 UTC 
A commit references this bug:

Author: bapt
Date: Sat Oct 22 19:51:32 UTC 2016
New revision: 307786
URL: https://svnweb.freebsd.org/changeset/base/307786

Log:
  Do not install NIS program rc script if WITHOUT_NIS is set

  PR:		213375
  Submitted by:	sergey@akhmatov.ru
  MFC after:	3 days

Changes:
  head/etc/rc.d/Makefile
  head/tools/build/mk/OptionalObsoleteFiles.inc
Comment 2 Baptiste Daroussin freebsd_committer freebsd_triage 2016-10-22 19:52:36 UTC 
actually the files were anyway installed, which I now fixed along without applying your patch.

Thanks
Comment 3 Enji Cooper freebsd_committer freebsd_triage 2016-10-22 20:20:23 UTC 
(In reply to Baptiste Daroussin from comment #2)

I hadn't gotten this far with cleaning this up.

There's a nasty rat's nest when dealing with the NIS stuff. If you uninstall some of the etc/rc.d, you will break boot ordering for those who set WITHOUT_NIS=.

I'll take the bug so I can officially finish it off.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-10-25 14:57:20 UTC 
A commit references this bug:

Author: bapt
Date: Tue Oct 25 14:56:42 UTC 2016
New revision: 307915
URL: https://svnweb.freebsd.org/changeset/base/307915

Log:
  MFC r307786:

  Do not install NIS program rc script if WITHOUT_NIS is set

  PR:		213375
  Submitted by:	sergey@akhmatov.ru

Changes:
_U  stable/11/
  stable/11/etc/rc.d/Makefile
  stable/11/tools/build/mk/OptionalObsoleteFiles.inc
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2017-08-24 14:05:55 UTC 
Committed back in 2016.