Created attachment 175760 [details] Patch for databases/pg_rman Current patch builds against pgsql:9.6, and builds without issue using poudriere testport under 11.0-RELEASE, 10.3-RELEASE, 10.2-RELEASE, 10.1-RELEASE, and 9.3-RELEASE.
Hi, I think it also needs an update to distinfo. SHA256 (pg_rman-1.3.3.tar.gz) = 9616f2b4e30164fb2bca7a0ffded4727ca4fe15ee4fc7a4bd423d9640bf53ec3 SIZE (pg_rman-1.3.3.tar.gz) = 110756 Also, which files is it supposed to download? I get: => ossc-db-pg_rman-1.3.3-REL9_6_STABLE_GH0.tar.gz is not in /usr/ports/databases/pg_rman/distinfo. => Either /usr/ports/databases/pg_rman/distinfo is out of date, or => ossc-db-pg_rman-1.3.3-REL9_6_STABLE_GH0.tar.gz is spelled incorrectly. *** Error code 1 But when I go to the github page, the path is like: https://github.com/ossc-db/pg_rman/archive/v1.3.3.tar.gz Finally, can this port be made to compile against different PostgreSQL-versions? I've defined different default versions for different builds...
Oh. My apologies I hadn't realized I had left out the distinfo file. I'm currently testing out a fix for your request for this port to build against different PostgreSQL versions. I shall update this ticket when I am finished. Thank you for looking at this! =)
Created attachment 176363 [details] Patch for databases/pg_rman with distinfo Includes distinfo for each supported PostgreSQL version, and a small substitution which changes the dot in the PGSQL_DEFAULT version to an underscore to grab the correct tag version. e.g. 9.3 to 9_3 Naming from the Github API (codeload.github.com) comes back as: account_name-repository_name-version-repository_tag.tar.gz e.g. ossc-db-pg_rman-1.3.3-REL9_3_STABLE_GH0.tar.gz And is reflected in the distinfo file. Added the LICENSE reference to the 3 Clause BSD License in the COPYRIGHT file in repository. Tested against 9.3-RELEASE, 10.1-RELEASE, 10.2-RELEASE, 10.3-RELEASE, 11.0-RELEASE in Poudriere against PostgreSQL 9.2, 9.3, 9.4, 9.5, and 9.6 for each release. Please let me know if you have further issues with this patch. Thank you. =)
Now it builds. FreeBSD 10.1-amd64 PostgreSQL 9.3 FreeBSD 10.1-amd64 PostgreSQL 9.5 Thanks a lot!
testbuilds@work
Created attachment 180528 [details] patch new patch, allows pg_rman to build
Ah, close, but not with older pg versions (9.3). http://people.freebsd.org/~pi/logs/databases__pg_rman-10i-1488708379.txt
Created attachment 180551 [details] pg_rman.shar with updated distinfo Hello Kurt, Thanks for looking at this. =) I updated the previous patch I had submitted. pg_rman has branches per PostgreSQL release that need to be downloaded, which is why I made the specific modifications to use the PostgreSQL version rather than just the straight tag name/hash for v1.3.3. Each of the branches is 1.3.3, but tailored specifically for a release of PostgreSQL, as noted here: https://github.com/ossc-db/pg_rman#branches I have built against the currently supported PostgreSQL and FreeBSD x86 versions, and all seems to have come back well. The logs are here: http://kassandry.net/drop/rman_all_supported_build.log.txt Please let me know if this patch is acceptable or if further changes need to be made.
fails to fetch, see http://people.freebsd.org/~pi/logs/databases__pg_rman-cur-1489520163.txt
Created attachment 180833 [details] pg_rman.shar with updated 9.6 distinfo The 9.6 branch was patched to fix issues with some regression test output, as noted here: https://github.com/ossc-db/pg_rman/commit/d087c8c4888f605bdd25f9a844a1c467029ac0a5 I updated the distinfo and re-tested everything with poudriere: http://kassandry.net/drop/rman_all_supported_build_2017-03-14.log The new shar file is attached. Thanks again for your help. =) Let me know if there are further issues.
fetch: https://codeload.github.com/ossc-db/pg_rman/tar.gz/REL9_3_STABLE?dummy=/ossc-db-pg_rman-1.3.3-REL9_3_STABLE_GH0.tar.gz: size of remote file is not known ossc-db-pg_rman-1.3.3-REL9_3_STABLE_GH0.tar.gz 0 B 0 Bps => Fetched file size mismatch (expected 111271, actual 112483) => Trying next site => Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/ossc-db-pg_rman-1.3.3-REL9_3_STABLE_GH0.tar.gz fetch: http://distcache.FreeBSD.org/ports-distfiles/ossc-db-pg_rman-1.3.3-REL9_3_STABLE_GH0.tar.gz: Not Found => Couldn't fetch it - please try to retrieve this
Created attachment 180860 [details] pg_rman.shar updated all distinfo Clearly I should have deleted previously downloaded distfiles, or else I would have caught this. =( My apologies. I've updated all of the files in distinfo again.
Testbuilds on 12a, 11a, 10i are fine 8-)
A commit references this bug: Author: pi Date: Thu Mar 16 03:40:05 UTC 2017 New revision: 436260 URL: https://svnweb.freebsd.org/changeset/ports/436260 Log: databases/pg_rman: update 1.2.3 -> 1.3.3, unbreak, new distsite PR: 213486 Changes: https://github.com/ossc-db/pg_rman/releases Submitted by: Lacey Powers <lacey.leanne@gmail.com> Reviewed by: rainer@ultra-secure.de Approved by: kuriyama (maintainer timeout) Changes: head/databases/pg_rman/Makefile head/databases/pg_rman/distinfo head/databases/pg_rman/pkg-descr
Committed, thanks! Please note that the distinfo file missed the TIMESTAMP and that USES should be sorted alphabetically.