Bug 213633 - audio/espeak: Fails to build when RUNTIME option selected
Summary: audio/espeak: Fails to build when RUNTIME option selected
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nicola Vitale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-20 00:10 UTC by Jason E. Hale
Modified: 2016-10-20 19:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (nivit)
koobs: merge-quarterly?


Attachments
Remove conditional post-patch (341 bytes, patch)
2016-10-20 00:10 UTC, Jason E. Hale
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale freebsd_committer 2016-10-20 00:10:07 UTC
Created attachment 175957 [details]
Remove conditional post-patch

audio/espeak fails to build when the RUNTIME option is selected:

c++  -fstack-protector -shared -Wl,-soname,libespeak.so.1 -o libespeak.so \
x_speak_lib.o x_compiledict.o x_dictionary.o x_intonation.o x_readclause.o x_setlengths.o x_numbers.o x_synth_mbrola.o x_synthdata.o x_synthesize.o x_translate.o x_mbrowrap.o x_tr_languages.o x_voices.o x_wavegen.o x_phonemelist.o x_espeak_command.o x_event.o x_fifo.o x_wave.o x_wave_pulse.o x_debug.o x_klatt.o x_sonic.o -lstdc++ -L/usr/local/lib -lpulse -lpulse-simple -lportaudio -lpthread
wavegen.o: In function `WavegenOpenSound()':
wavegen.cpp:(.text+0xf0): undefined reference to `Pa_StreamActive'
wavegen.o: In function `WavegenCloseSound()':
wavegen.cpp:(.text+0x3d5): undefined reference to `Pa_StreamActive'
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[2]: *** [Makefile:105: speak] Error 1
gmake[2]: *** Waiting for unfinished jobs....
mv libespeak.so libespeak.so.1.1.48
/bin/ln -sf libespeak.so.1.1.48 libespeak.so.1
/bin/ln -sf libespeak.so.1 libespeak.so
gmake[2]: Leaving directory '/usr/home/Jason/src/freebsd/ports/audio/espeak/work/espeak-1.48.04-source/src'
===> Compilation failed unexpectedly.

This is due to the fact that ${WRKSRC}/src/portaudio19.h should replace ${WRKSRC}/src/portaudio.h, but in the port Makefile this move is conditionalized to only happen when the PORTAUDIO option is selected.

The fix is just to remove the condition, as it is not neccessary even if PULSEAUDIO is selected. Patch is attached.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-20 03:14:07 UTC
Comment on attachment 175957 [details]
Remove conditional post-patch

This change is blanket approved (Approved by: portmgr (blanket)), implicit approval.

@Jason, you are free to assign/commit/mfh this change
Comment 2 commit-hook freebsd_committer 2016-10-20 03:52:06 UTC
A commit references this bug:

Author: jhale
Date: Thu Oct 20 03:51:28 UTC 2016
New revision: 424305
URL: https://svnweb.freebsd.org/changeset/ports/424305

Log:
  Fix build when RUNTIME option is selected

  PR:		213633
  Approved by:	portmgr (blanket)
  MFH:		2016Q4

Changes:
  head/audio/espeak/Makefile
Comment 3 commit-hook freebsd_committer 2016-10-20 19:16:35 UTC
A commit references this bug:

Author: jhale
Date: Thu Oct 20 19:15:45 UTC 2016
New revision: 424350
URL: https://svnweb.freebsd.org/changeset/ports/424350

Log:
  MFH: r424305

  Fix build when RUNTIME option is selected

  PR:		213633
  Approved by:	portmgr (blanket)

  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/audio/espeak/Makefile
Comment 4 Jason E. Hale freebsd_committer 2016-10-20 19:27:53 UTC
Committed and merged into quarterly branch.