Bug 213697 - [PATCH] devel/arduino-builder: Move GOPATH to GO_ENV, respect GO_ENV
Summary: [PATCH] devel/arduino-builder: Move GOPATH to GO_ENV, respect GO_ENV
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-22 04:51 UTC by Kyle Evans
Modified: 2016-10-22 20:31 UTC (History)
1 user (show)

See Also:


Attachments
svn(1) diff of devel/arduino-builder (1.12 KB, patch)
2016-10-22 04:51 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2016-10-22 04:51:54 UTC
Created attachment 176053 [details]
svn(1) diff of devel/arduino-builder

This port does not currently respect GO_ENV, which can be kind of unfriendly if the it has been set in /etc/make.conf or otherwise.

Also, if one wanted to cross-build this port for another $ARCH, GO_ENV+= GOOS=freebsd GOARCH=arm could get the job done without requiring any modifications to the port itself. This specific case can be helpful when, for instance, lang/go14 won't build in qemu and building lang/go14 -> lang/go -> devel/arduino-builder on an RPI B simply does not sound like a fun time.

Bump PORTREVISION for the change, since GO_ENV being taken into account could effectively alter the build results. `portlint` is still happy, and a poudriere test run works well.
Comment 1 commit-hook freebsd_committer 2016-10-22 20:27:24 UTC
A commit references this bug:

Author: bsam
Date: Sat Oct 22 20:27:17 UTC 2016
New revision: 424484
URL: https://svnweb.freebsd.org/changeset/ports/424484

Log:
  devel/arduino-builder: Move GOPATH to GO_ENV, respect GO_ENV.

  PR:		213697
  Submitted by:	Kyle Evans <bsdports@kyle-evans.net> (maintainer)

Changes:
  head/devel/arduino-builder/Makefile
Comment 2 Boris Samorodov freebsd_committer 2016-10-22 20:31:51 UTC
Committed, thanks!
PS. Assuming that USE_GITHUB at the patch was touched by an accident.