Bug 213833 - lang/basic256: Remove incorrect use of %%QT_LIBDIR%% in pkg-plist
Summary: lang/basic256: Remove incorrect use of %%QT_LIBDIR%% in pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2016-10-27 12:33 UTC by Tobias C. Berner
Modified: 2016-10-28 13:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (fernape)
koobs: merge-quarterly?

Attachments
sed s|%%QT_LIBDIR%%|lib|g' (12.52 KB, patch)
2016-10-27 12:33 UTC, Tobias C. Berner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer freebsd_triage 2016-10-27 12:33:03 UTC 
Created attachment 176217 [details]
sed s|%%QT_LIBDIR%%|lib|g'

The plist of lang/basic256 uses %%QT_LIBDIR%% wrongly. It should only be used when one needs the relative path to the Qt libraries from ${LOCALBASE}. Not to simply mean "lib".
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-27 13:00:00 UTC 
Reporter is committer , assign accordingly.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-10-27 13:00:52 UTC 
@Tobias This change comes under blanket (implicit) approval and may be committed (if/when tested) without maintainer approval. Please include in the commit message:

Approved by: portmgr (blanket)
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2016-10-27 20:39:14 UTC 
Comment on attachment 176217 [details]
sed s|%%QT_LIBDIR%%|lib|g'

I approve the patch. Thank you very much for taking the time for improving the port.

Port test OK.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-10-28 13:06:27 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Oct 28 13:06:08 UTC 2016
New revision: 424831
URL: https://svnweb.freebsd.org/changeset/ports/424831

Log:
  Remove wrongly used QT-related plist-subs from plist

  %%QT_BINDIR%% and %%QT_LIBDIR%% represent the relative location of the
  Qt binaries and libraries respectively -- they are only 'bin' and 'lib'
  by chance, and should not be used that way.

  Approved by: portmgr (blanket), rakuco (mentor)
  PR:	213833

Changes:
  head/lang/basic256/pkg-plist
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2016-10-28 13:07:37 UTC 
Commited. Thanks.