Bug 213836 - [Patch] security/ngrok: update to 2.1.18, clean Makefile
Summary: [Patch] security/ngrok: update to 2.1.18, clean Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-27 19:08 UTC by Lars Engels
Modified: 2016-12-05 19:42 UTC (History)
2 users (show)

See Also:
jhixson: maintainer-feedback+

Attachments
patch (1.31 KB, patch)
2016-10-27 19:08 UTC, Lars Engels 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Engels freebsd_committer freebsd_triage 2016-10-27 19:08:51 UTC 
Created attachment 176223 [details]
patch

The attached patch does:

- Update to 2.1.18
- Remove unnecessary inclusion of bsd.port.options.mk
- Use ${INSTALL_PROGRAM} so the resulting binary gets stripped
Comment 1 John Hixson freebsd_committer freebsd_triage 2016-10-31 20:11:27 UTC 
Do I need to do anything here?
Comment 2 Joseph Mingrone freebsd_committer freebsd_triage 2016-11-01 07:29:41 UTC 
(In reply to jhixson from comment #1)

If the changes are acceptable to you, you approve them by updating the maintainer-feedback field to '+'.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-12-05 19:41:28 UTC 
A commit references this bug:

Author: jrm
Date: Mon Dec  5 19:40:49 UTC 2016
New revision: 427917
URL: https://svnweb.freebsd.org/changeset/ports/427917

Log:
  security/ngrok: update to 2.1.18

  While here, add license information.

  PR:		213836
  Submitted by:	lme
  Reviewed by:	mat
  Approved by:	swills (mentor)
  Differential Revision:	https://reviews.freebsd.org/D8684

Changes:
  head/security/ngrok/Makefile
  head/security/ngrok/distinfo
  head/security/ngrok/pkg-descr
Comment 4 Joseph Mingrone freebsd_committer freebsd_triage 2016-12-05 19:42:53 UTC 
Committed.  Thanks.