Bug 213838 - [patch] devel/arduino-core: Enable SAM platforms for use in the IDE, simplify package_index_bundled.json for future updating
Summary: [patch] devel/arduino-core: Enable SAM platforms for use in the IDE, simplify...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-10-27 19:49 UTC by Kyle Evans
Modified: 2016-10-28 21:37 UTC (History)
1 user (show)

See Also:


Attachments
svn(1) diff of devel/arduino-core (10.80 KB, patch)
2016-10-27 19:49 UTC, Kyle Evans
kevans: maintainer-approval+
Details | Diff
svn(1) diff of devel/arduino-core (9.41 KB, patch)
2016-10-28 20:41 UTC, Kyle Evans
kevans: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer 2016-10-27 19:49:16 UTC
Created attachment 176225 [details]
svn(1) diff of devel/arduino-core

This update enables SAM platforms (Due [Programming Port], Due [Native Port]) for use in the IDE, and simplifies package_index_bundled.json for future maintainability with our packages.

Do note that programming a Due from the IDE *does not* currently work, but compilation is fine. For reasons not yet known to me, the IDE is failing to do the 1200bps reset hack on before passing the .hex file over to bossac. I will address this in short-ish time as I look this over tonight -- in the meantime, the Due can be programmed manually by compiling with the IDE and then doing a magical incantation along these lines:

stty -f /dev/$port 1200
stty stop /dev/$port
bossac --port=/dev/$port -U false -e -w true -b $hexfile -R

whilst connected to the programming port of the Due.
Comment 1 Boris Samorodov freebsd_committer 2016-10-27 19:56:41 UTC
Take.
Comment 2 Boris Samorodov freebsd_committer 2016-10-28 19:58:59 UTC
Hi Kyle, two notes:
. (critical) make patch does not work, at least files/patch-hardware_arduino_samd_platform.txt -- there is no hardware/arduino/samd directory;
. (non-critical) there are some hunks at the patch which change only timings of patches, such hunks add unneeded noise to functional changes and are disliked by the community.
Otherwise good job, thank you.
Comment 3 Kyle Evans freebsd_committer 2016-10-28 20:41:29 UTC
Created attachment 176254 [details]
svn(1) diff of devel/arduino-core

Whoops, my apologies. All of my build machines and development machines have SAMD set, so I do the dumb...I really need to setup a clean environment for this.

This version:

* Moves the SAMD patch to extrapatch-hardware_arduino_samd_platform.txt, and adds this to SAMD_EXTRA_PATCHES
* I reverted the files that were simply re-rolled and no different, leaving the timestamps the same
Comment 4 commit-hook freebsd_committer 2016-10-28 21:32:43 UTC
A commit references this bug:

Author: bsam
Date: Fri Oct 28 21:32:02 UTC 2016
New revision: 424885
URL: https://svnweb.freebsd.org/changeset/ports/424885

Log:
  devel/arduino-core: Enable SAM platforms for use in the IDE,
  simplify package_index_bundled.json.

  PR:		213838
  Submitted by:	Kyle Enavs <bsdports@kyle-evans.net> (maintainer)

Changes:
  head/devel/arduino-core/Makefile
  head/devel/arduino-core/files/extrapatch-hardware_arduino_samd_platform.txt
  head/devel/arduino-core/files/patch-hardware_arduino_sam_platform.txt
  head/devel/arduino-core/files/patch-hardware_package__index__bundled.json
Comment 5 Boris Samorodov freebsd_committer 2016-10-28 21:37:14 UTC
Committed, thanks!

You wrote:
---
* I reverted the files that were simply re-rolled and no different, leaving the timestamps the same
---
Hm, I never think about doing it that way. ;-)
I usually review my diff files before submitting and just remove unneeded hunks.