Bug 213854 - sysutils/screenfetch: fix
Summary: sysutils/screenfetch: fix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-28 14:15 UTC by Dmitry Marakasov
Modified: 2016-11-11 19:41 UTC (History)
0 users

See Also:
jgh: maintainer-feedback+


Attachments
Patch (2.00 KB, patch)
2016-10-28 14:15 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2016-10-28 14:15:57 UTC
Created attachment 176246 [details]
Patch

There are two problems in screenfetch on FreeBSD:

- It doesn't work in some cases. Works fine on my desktop, but fails reliable in poudriere. No idea what exactly causes this:

$ screenfetch
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor
/usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
/usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor

This was fixed upstream, https://github.com/KittyKatt/screenFetch/commit/5774f849d18295715392e56dbc27998de518cec2

- It's unable to detect FreeBSD system when there's no /var/run/dmesg.boot (e.g. again in poudreire jail). Add proper detection based on `uname -o` output. Upstream PR: https://github.com/KittyKatt/screenFetch/pull/402

While here, fix LICENSE, add LICENSE_FILE, switch to license helpers and add a very simple test.
Comment 1 commit-hook freebsd_committer 2016-11-11 19:41:38 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Nov 11 19:40:50 UTC 2016
New revision: 425906
URL: https://svnweb.freebsd.org/changeset/ports/425906

Log:
  - Fix LICENSE
  - Add LICENSE_FILE
  - Add NO_ARCH
  - Switch to options helpers
  - Add simple test
  - Fix FreeBSD detection
  - Fix screenfetch failures in some cases due to not clearly understood reason:

  /usr/local/bin/screenfetch: line 4156: /dev/fd/62: Operation not supported
  /usr/local/bin/screenfetch: line 4157: 3: Bad file descriptor

  by importing upstream fix.

  PR:		213854
  Submitted by:	amdmi3
  Approved by:	jgh (maintainer)

Changes:
  head/sysutils/screenfetch/Makefile
  head/sysutils/screenfetch/files/
  head/sysutils/screenfetch/files/patch-screenfetch-dev