Bug 213892 - net-im/libpurple: switch gstreamer dependency to 1.0
Summary: net-im/libpurple: switch gstreamer dependency to 1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-29 18:06 UTC by Matthieu Volat
Modified: 2016-12-23 23:16 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
libpurple: switch to gstreamer 1.0 (563 bytes, text/plain)
2016-10-29 18:06 UTC, Matthieu Volat
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Volat 2016-10-29 18:06:26 UTC
Created attachment 176287 [details]
libpurple: switch to gstreamer 1.0

Hi,

As gstreamer 0.10 packages are unmaintained since 5 years, have now security issues, and pidgin/libpurple added gstreamer 1.0 support for a while, I'd like to propose to switch the gstreamer dependency of net-im/libpurple to 1.0.

Here's a patch that do the deed, there's no issue to my knowledge, having used this for around a year on 3 different computers. Pidgin port do not need to be updated itself.

Minimal QA:
# make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)

Portlint is not happy, but nothing seems related to this change:
WARN: Makefile: NCURSES appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.
WARN: Makefile: CAP appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.
WARN: Makefile: GTKSPELL appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
WARN: Makefile: unless this is a master port, PORTNAME has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
WARN: Makefile: Consider defining LICENSE.
WARN: /usr/ports/net-im/libpurple/files/patch-configure: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
WARN: /usr/ports/net-im/libpurple/files/patch-finch_libgnt_gntmain.c: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
0 fatal errors and 10 warnings found.
Comment 1 Joe Marcus Clarke freebsd_committer 2016-12-23 23:16:10 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2016-12-23 23:16:32 UTC
A commit references this bug:

Author: marcus
Date: Fri Dec 23 23:15:59 UTC 2016
New revision: 429291
URL: https://svnweb.freebsd.org/changeset/ports/429291

Log:
  Switch GStreamer dependency to Gst1.

  PR:		213892
  Submitted by:	Matthieu Volat <mazhe@alkumuna.eu>

Changes:
  head/net-im/libpurple/Makefile