Bug 213935 - freebsd-update upgrade from 9.3 to 11.0 failed.
Summary: freebsd-update upgrade from 9.3 to 11.0 failed.
Status: Closed Overcome By Events
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 9.3-RELEASE
Hardware: Any Any
: --- Affects Some People
Assignee: Graham Perrin
URL: https://www.freebsd.org/security/unsu...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-31 04:42 UTC by hsakamt
Modified: 2023-10-06 16:48 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hsakamt 2016-10-31 04:42:35 UTC
When I try to upgrade 9.3-RELEASE-p49 to 11.0-RELEASE, 
It failed with:
# freebsd-update upgrade -r 11.0-RELEASE
  :
The update metadata is correctly signed, but
failed an integrity check.
Cowardly refusing to proceed any further.
# freebsd-update fetch
  :
No updates needed to update system to 9.3-RELEASE-p49.


Because some files in 11.0 include ',' character in a path.
This patch fix the problem(still in progress but looks ok).

--- /usr/sbin/freebsd-update.orig	2016-10-31 13:10:47.000000000 +0900
+++ /usr/sbin/freebsd-update	2016-10-31 13:10:50.000000000 +0900
@@ -1223,7 +1223,7 @@
 	# Some aliases to save space later: ${P} is a character which can
 	# appear in a path; ${M} is the four numeric metadata fields; and
 	# ${H} is a sha256 hash.
-	P="[-+./:=%@_[~[:alnum:]]"
+	P="[-+.,/:=%@_[~[:alnum:]]"
 	M="[0-9]+\|[0-9]+\|[0-9]+\|[0-9]+"
 	H="[0-9a-f]{64}"
Comment 1 Anton Saietskii 2016-11-14 13:51:55 UTC
I think you should not skip intermediate versions. Try this:
1. Update to latest 9.x
2. Update to latest 10.x
3. Update to 11
Comment 2 hsakamt 2016-11-14 23:52:34 UTC
(In reply to Anton Sayetsky from comment #1)

But the Official Handbook says:

The freebsd-update(8) utility supports binary upgrades of i386 and amd64 systems running earlier FreeBSD releases. Systems running 9.3-RELEASE, 10.1-RELEASE, 10.2-RELEASE, 10.3-RELEASE, 11.0-RC[123] can upgrade as follows:

# freebsd-update fetch
# freebsd-update install

(https://www.freebsd.org/releases/11.0R/installation.html)

So, I think that it also supports upgrading from 9.3-RELEASE.
Comment 3 hsakamt 2016-11-15 00:17:33 UTC
By using this patch binary update from 9.3 to 11.0 succeeded.
The problem file seems to be under /usr/src/sys/gnu/dts/include/dt-bindings/ (see below).
So probably it is a problem that comes out only when installing the src/sys component.


Files:
/usr/src/sys/gnu/dts/include/dt-bindings/clock/alphascale,asm9260.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/lsi,axm5516-clks.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/marvell,mmp2.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/marvell,pxa168.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/marvell,pxa1928.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/marvell,pxa910.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/maxim,max77686.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/maxim,max77802.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,gcc-apq8084.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,gcc-ipq806x.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,gcc-msm8660.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,gcc-msm8916.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,gcc-msm8960.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,gcc-msm8974.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,gcc-msm8996.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,lcc-ipq806x.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,lcc-msm8960.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,mmcc-apq8084.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,mmcc-msm8960.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,mmcc-msm8974.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/qcom,mmcc-msm8996.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/rockchip,rk808.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/samsung,s2mps11.h
/usr/src/sys/gnu/dts/include/dt-bindings/clock/samsung,s3c64xx-clock.h
/usr/src/sys/gnu/dts/include/dt-bindings/iio/qcom,spmi-vadc.h
/usr/src/sys/gnu/dts/include/dt-bindings/pinctrl/qcom,pmic-gpio.h
/usr/src/sys/gnu/dts/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
/usr/src/sys/gnu/dts/include/dt-bindings/regulator/maxim,max77802.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/altr,rst-mgr-a10.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/altr,rst-mgr.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/hisi,hi6220-resets.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,gcc-apq8084.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,gcc-ipq806x.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,gcc-msm8660.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,gcc-msm8916.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,gcc-msm8960.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,gcc-msm8974.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,mmcc-apq8084.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,mmcc-msm8960.h
/usr/src/sys/gnu/dts/include/dt-bindings/reset/qcom,mmcc-msm8974.h
/usr/src/sys/gnu/dts/include/dt-bindings/soc/qcom,gsbi.h
Comment 4 Graham Perrin 2023-10-06 16:40:31 UTC
(In reply to hsakamt from comment #0)

>> ⋯
>> Cowardly refusing to proceed any further.
>> ⋯

Strictly speaking, bug 264205 might have become a duplicate of this earlier report. 

As 264205 is very recently updated: please follow the more recent report. 


(In reply to hsakamt from comment #2)

Please follow bug 270338 for relevant improvements to the FreeBSD Handbook. 


(In reply to Anton Saietskii from comment #1)

11.4-RELEASE reached the end of its life more than two years ago. 

Recent fixes to freebsd-update include these, on the releng/12.4 branch: 


<https://github.com/freebsd/freebsd-src/commit/193b7e3d0af5205f770c30620711889eff324ae8>

> freebsd-update: Fix merging already-updated files

<https://github.com/freebsd/freebsd-src/commit/0eb6c273622d77a89115e7d4f01609eefc50b33c>

> freebsd-update: handle file -> directory on upgrade


Thank you

*** This bug has been marked as a duplicate of bug 264205 ***