Bug 214168 - devel/p5-Coro: unbreak for >= perl5.24
Summary: devel/p5-Coro: unbreak for >= perl5.24
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-03 17:13 UTC by Kurt Jaeger
Modified: 2016-11-03 22:59 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback+

Attachments
patch (2.33 KB, patch)
2016-11-03 17:13 UTC, Kurt Jaeger 		no flags Details | Diff
patch-v2 (2.12 KB, patch)
2016-11-03 22:26 UTC, Kurt Jaeger 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2016-11-03 17:13:05 UTC 
Created attachment 176594 [details]
patch

testbuilds are fine, builds of dependencies are @work

Unsure about the version numbering, probably needs fix.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2016-11-03 22:22:23 UTC 
Please, can you redo the patch without changing PORTVERSION ?
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2016-11-03 22:26:31 UTC 
Created attachment 176597 [details]
patch-v2

without the version number bug
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-11-03 22:26:56 UTC 
That should do it, no ?
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2016-11-03 22:27:11 UTC 
It even gives PASS to make test 8-}
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2016-11-03 22:46:29 UTC 
The patch to the Makefile looks good to me, approved.
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2016-11-03 22:58:58 UTC 
Committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-11-03 22:59:09 UTC 
A commit references this bug:

Author: pi
Date: Thu Nov  3 22:58:27 UTC 2016
New revision: 425278
URL: https://svnweb.freebsd.org/changeset/ports/425278

Log:
  devel/p5-Coro: add patch to work with perl 5.24 and up

  - Patch from debian as described in
    https://rt.cpan.org/Public/Bug/Display.html?id=114708

  PR:		214168
  Reported by:	tom
  Approved by:	mat

Changes:
  head/devel/p5-Coro/Makefile
  head/devel/p5-Coro/files/patch-Coro-State.xs
  head/devel/p5-Coro/files/patch-Coro-libcoro-coro.c