Bug 214183 - audio/acoustid-fingerprinter: fails to build with ffmpeg 3.x
Summary: audio/acoustid-fingerprinter: fails to build with ffmpeg 3.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords: needs-patch
Depends on:
Blocks: 207547
  Show dependency tree / graph
 
Reported: 2016-11-04 04:00 UTC by Jan Beich
Modified: 2016-11-04 14:58 UTC (History)
2 users (show)

See Also:
jbeich: maintainer-feedback? (jhale)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-11-04 04:00:10 UTC 
In file included from decoder.cpp:1:
decoder.h:172:53: warning: 'codec' is deprecated [-Wdeprecated-declarations]
                AVCodecContext *avctx = m_format_ctx->streams[i]->codec;
                                                                  ^
/usr/local/include/libavformat/avformat.h:880:21: note: 'codec' declared here
    AVCodecContext *codec;
                    ^
In file included from decoder.cpp:1:
decoder.h:257:40: error: use of undeclared identifier 'avcodec_decode_audio3'; did you mean 'avcodec_decode_audio4'?
                        int consumed = avcodec_decode_audio3(
                                       ^~~~~~~~~~~~~~~~~~~~~
                                       avcodec_decode_audio4
/usr/local/include/libavcodec/avcodec.h:4704:5: note: 'avcodec_decode_audio4' declared here
int avcodec_decode_audio4(AVCodecContext *avctx, AVFrame *frame,
    ^
In file included from decoder.cpp:1:
decoder.h:258:46: error: cannot initialize a parameter of type 'AVFrame *' with an rvalue of type 'int16_t *' (aka 'short *')
                                m_codec_ctx, (int16_t *)m_buffer1, &buffer_size,
                                             ^~~~~~~~~~~~~~~~~~~~
/usr/local/include/libavcodec/avcodec.h:4704:59: note: passing argument to parameter 'frame' here
int avcodec_decode_audio4(AVCodecContext *avctx, AVFrame *frame,
                                                          ^
In file included from decoder.cpp:1:
decoder.h:257:40: warning: 'avcodec_decode_audio4' is deprecated [-Wdeprecated-declarations]
                        int consumed = avcodec_decode_audio3(
                                       ^
/usr/local/include/libavcodec/avcodec.h:4704:5: note: 'avcodec_decode_audio4' declared here
int avcodec_decode_audio4(AVCodecContext *avctx, AVFrame *frame,
    ^
In file included from decoder.cpp:1:
decoder.h:315:4: warning: 'av_free_packet' is deprecated [-Wdeprecated-declarations]
                        av_free_packet(&packet);
                        ^
/usr/local/include/libavcodec/avcodec.h:4414:6: note: 'av_free_packet' declared here
void av_free_packet(AVPacket *pkt);
     ^
3 warnings and 2 errors generated.

http://package23.nyi.freebsd.org/data/103i386-default-PR207547/2016-10-04_18h24m30s/logs/errors/acoustid-fingerprinter-0.6_3.log
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-11-04 14:55:50 UTC 
A commit references this bug:

Author: jhale
Date: Fri Nov  4 14:55:05 UTC 2016
New revision: 425327
URL: https://svnweb.freebsd.org/changeset/ports/425327

Log:
  - Sync with Github 632e879 to allow building with upcoming ffmpeg 3.x [1]
  - This includes several changes that were already made by local patches
  - Changes since release:
    - Fix taglib detection
    - Fix build with ffmpeg 3.x
    - Fix build with gcc 6
  - Add dependency on desktop-file-utils to satisfy stage-qa
  - Bump PORTREVISION

  PR:		214183 [1]
  Submitted by:	jbeich [1]

Changes:
  head/audio/acoustid-fingerprinter/Makefile
  head/audio/acoustid-fingerprinter/distinfo
  head/audio/acoustid-fingerprinter/files/
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2016-11-04 14:58:17 UTC 
Build tested with ffmpeg-3.2 (OK).