Bug 214212 - net/megatools: update to 1.9.98
Summary: net/megatools: update to 1.9.98
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-04 12:50 UTC by Max Kostikov
Modified: 2016-11-06 14:21 UTC (History)
2 users (show)

See Also:


Attachments
diff to 1.9.98 (2.36 KB, patch)
2016-11-04 12:50 UTC, Max Kostikov
no flags Details | Diff
megatools 1.9.98 additional changes (3.90 KB, patch)
2016-11-06 10:56 UTC, Jason E. Hale
max: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Kostikov 2016-11-04 12:50:53 UTC
Created attachment 176618 [details]
diff to 1.9.98

Bugfix release with some UI imporvements
Comment 1 Jason E. Hale freebsd_committer 2016-11-06 10:56:37 UTC
Created attachment 176681 [details]
megatools 1.9.98 additional changes

I have a few changes for you to review.

1. Convert USE_OPENSSL -> USES=ssl
2. Add USES=gettext-runtime as this links to libintl.so
3. Remove unused CONFIGURE_ARGS
4. Unsilence the build process (we like verbose logs)
5. Add patch to fix build with FreeBSD 9.x and libressl
Comment 2 Max Kostikov 2016-11-06 11:27:50 UTC
(In reply to Jason E. Hale from comment #1)
Wow, it looks good!
Thank you very much.
And I think it will be good idea to commit your LibresSSL compatibility changes to Megatools GIT here https://github.com/megous/megatools
Comment 3 Jason E. Hale freebsd_committer 2016-11-06 11:56:05 UTC
(In reply to Max Kostikov from comment #2)

Looks like they added LibreSSL support 2 days ago:
https://github.com/megous/megatools/commit/3111b1b11330feb8b81d163bce67c5579a289796
Pretty much the same thing I did.  Although if they do release a new version, #include <openssl/modes.h> still needs to be conditionalized to support base OpenSSL in 9.x.  Since 9.x is EOL soon, I'm not sure that would be worth upstreaming.
Comment 4 Max Kostikov 2016-11-06 12:11:36 UTC
(In reply to Jason E. Hale from comment #3)
I have no idea when author will release a new version with LibreSSL support so your patch is usefull at this moment.
While 9.x it supported we should support it in ports too.
Comment 5 commit-hook freebsd_committer 2016-11-06 14:16:57 UTC
A commit references this bug:

Author: jhale
Date: Sun Nov  6 14:16:11 UTC 2016
New revision: 425492
URL: https://svnweb.freebsd.org/changeset/ports/425492

Log:
  Update to 1.9.98

  PR:		214212
  Submitted by:	Max Kostikov <max@kostikov.co> (maintainer)

Changes:
  head/net/megatools/Makefile
  head/net/megatools/distinfo
  head/net/megatools/files/
  head/net/megatools/files/patch-lib_mega.c
  head/net/megatools/pkg-plist