Bug 214213 - cad/ngspice_rework distinfo doesn't match Makefile
Summary: cad/ngspice_rework distinfo doesn't match Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-04 13:16 UTC by Gary
Modified: 2016-11-04 20:04 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (kevinz5000)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gary 2016-11-04 13:16:52 UTC
Makefile has

PORTVERSION=    28

distinfo has

SHA256 (ngspice-26.tar.gz) = 51e230c8b720802d93747bc580c0a29d1fb530f3dd06f213b6a700ca9a4d0108
SIZE (ngspice-26.tar.gz) = 6925987

Results in

=======================<phase: check-sanity   >============================
===>  Found saved configuration for ngspice_rework-25
===========================================================================
=======================<phase: pkg-depends    >============================
===>   ngspice_rework-28 depends on file: /usr/local/sbin/pkg - not found
===>   Installing existing package /packages/All/pkg-1.9.3.txz
[10_2_amd64-local-job-02] Installing pkg-1.9.3...
[10_2_amd64-local-job-02] Extracting pkg-1.9.3: .......... done
===>   ngspice_rework-28 depends on file: /usr/local/sbin/pkg - found
===>   Returning to build of ngspice_rework-28
===========================================================================
=======================<phase: fetch-depends  >============================
===========================================================================
=======================<phase: fetch          >============================
===>  Found saved configuration for ngspice_rework-25
=> ngspice-28.tar.gz is not in /usr/ports/cad/ngspice_rework/distinfo.
=> Either /usr/ports/cad/ngspice_rework/distinfo is out of date, or
=> ngspice-28.tar.gz is spelled incorrectly.
*** Error code 1

Stop.
make: stopped in /usr/ports/cad/ngspice_rework
====>> Cleaning up wrkdir
===>  Cleaning for ngspice_rework-28
Comment 1 Gary 2016-11-04 13:18:41 UTC
Copy marino@ as the committer of the last 2 fixes
Comment 2 Kevin Zheng 2016-11-04 15:10:20 UTC
Looks like PORTVERSION got bumped instead of PORTREVISION. Fix is to bring PORTVERSION back down. I'll have a patch soon. Does this require bumping PORTEPOCH?
Comment 3 John Marino freebsd_committer 2016-11-04 17:06:46 UTC
no, because it was never possible to build it.  THere's nobody with version 28 installed.
Comment 4 John Marino freebsd_committer 2016-11-04 17:07:09 UTC
the fix is just move to 26 and add PORTREVISION=1
?
Comment 5 Kevin Zheng 2016-11-04 19:54:34 UTC
I believe that's correct.
Comment 6 commit-hook freebsd_committer 2016-11-04 19:59:26 UTC
A commit references this bug:

Author: marino
Date: Fri Nov  4 19:59:09 UTC 2016
New revision: 425357
URL: https://svnweb.freebsd.org/changeset/ports/425357

Log:
  cad/ngspice_rework: Fix fetch broken by version bump

  I confused PORTVERSION with PORTREVISION and bumped the wrong item.
  Restore the old version and add PORTREVISION.  No epoch is necessary
  because it wasn't possible to build version 27 or 28.

  PR:		214213

Changes:
  head/cad/ngspice_rework/Makefile
Comment 7 John Marino freebsd_committer 2016-11-04 20:04:44 UTC
thanks for the report, Gary!