Bug 214355 - [exp-run] devel/py-qt5 Update PyQt to 5.6.2
Summary: [exp-run] devel/py-qt5 Update PyQt to 5.6.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: kde
URL: https://reviews.freebsd.org/D8408
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-09 10:25 UTC by groot
Modified: 2016-11-13 20:22 UTC (History)
4 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
svn diff against ports (11.07 KB, patch)
2016-11-09 10:25 UTC, groot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description groot 2016-11-09 10:25:30 UTC
Created attachment 176813 [details]
svn diff against ports

This updates PyQt to 5.6.2, matching the Qt version in ports (see PR 213530). Also updates sip to 4.18.

Review was D8408.

Tested by running Calibre (one of the very few clients of PyQT 5), which seems to work.
Comment 1 Tobias C. Berner freebsd_committer 2016-11-09 10:33:40 UTC
kde@ would like to ask for an exp-run of this :)

mfg Tobias
Comment 2 Antoine Brodin freebsd_committer 2016-11-13 07:25:36 UTC
Exp-run looks fine.
Comment 3 Rainer Hurling 2016-11-13 09:10:21 UTC
With actual PyQt 5.51, when I try to install devel/py-qt5-core for python 3.5, with installed python 2.7 and py27-qt5-core, I get a conflict with the pyuic5 binary:


# cd /usr/ports/devel/py-qt5-core
# make PYTHON_VERSION=3.5 clean install
[..snip..]
===>   Registering installation for py35-qt5-core-5.5.1
Installing py35-qt5-core-5.5.1...
pkg-static: py35-qt5-core-5.5.1 conflicts with py27-qt5-core-5.5.1 (installs files into the same place).  Problematic file: /usr/local/bin/pyuic5
*** Error code 70
Stop.
make[1]: stopped in /usr/ports/devel/py-qt5-core
*** Error code 1


Is there any experience with the diff for PyQt 5.6 in relation to that conflict with pyuic5?

[Sorry, that I did not test it for myself. ATM, there is no box free for testing :( ]
Comment 4 Raphael Kubo da Costa freebsd_committer 2016-11-13 11:28:27 UTC
(In reply to Rainer Hurling from comment #3)
> With actual PyQt 5.51, when I try to install devel/py-qt5-core for python
> 3.5, with installed python 2.7 and py27-qt5-core, I get a conflict with the
> pyuic5 binary:

Does it work if you add "concurrent" to the USE_PYTHON line in devel/py-qt5-core's Makefile?
Comment 5 commit-hook freebsd_committer 2016-11-13 20:19:17 UTC
A commit references this bug:

Author: tcberner
Date: Sun Nov 13 20:19:12 UTC 2016
New revision: 426062
URL: https://svnweb.freebsd.org/changeset/ports/426062

Log:
  Udpate PyQt5 to 5.6.2

  Update PyQt from 5.5.1 to 5.6.2 to match the Qt updates that have
  already landed in the ports tree.

  PR:		214355
  Submitted by:	Adriaan de Groot <groot@kde.org>
  Reviewed by:	rakuco, tcberner
  Approved by:	rakuco (mentor)
  Exp-Run by:	antoine
  Differential Revision:	https://reviews.freebsd.org/D8408

Changes:
  head/Mk/Uses/pyqt.mk
  head/devel/py-qt5/distinfo
  head/devel/py-qt5-core/files/patch-configure.py
  head/devel/py-qt5-core/pkg-plist
  head/devel/py-sip/distinfo
  head/devel/py-sip/pkg-plist
  head/misc/py-qt5-demo/pkg-plist
  head/misc/py-qt5-doc/pkg-plist
  head/x11-toolkits/py-qt5-gui/pkg-plist
Comment 6 Tobias C. Berner freebsd_committer 2016-11-13 20:22:33 UTC
Committed. Thanks.