Bug 214372 - www/subsonic-standalone: Cannot set both HTTP and HTTPS ports
Summary: www/subsonic-standalone: Cannot set both HTTP and HTTPS ports
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Jeremie Le Hen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-09 20:47 UTC by John Vilk
Modified: 2018-01-14 00:58 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jlh)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Vilk 2016-11-09 20:47:05 UTC
The latest subsonic-standalone package has a single configuration option for port. The port is used for HTTP when SSL is disabled, and HTTPS when SSL is enabled. When SSL is enabled, the HTTP port is set to 0.

It makes complete logical sense to disable HTTP when HTTPS is enabled. Unfortunately, Subsonic currently has a bug that prevents Subsonic Premium subdomains from functioning when -Dsubsonic.port is set to 0 and inaccessible externally [0].

To work around this bug (at least until upstream fixes it) and to support dual http/https configurations for those that want it, I believe it should be possible to configure both ports independently. The older version of this package exposed subsonic_http_port and subsonic_https_port, but I believe the current configuration behavior is cleaner/safer for most users.

My suggestion: expose a subsonic_https_port option. If that option is explicitly present, use subsonic_port for HTTP and subsonic_https_port for HTTPS. Otherwise, use the current behavior that disables HTTP.

Thoughts?

[0] https://sourceforge.net/p/subsonic/bugs/199/
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-01-14 00:58:28 UTC
Maintainer feedback?