Bug 214388 - [patch] devel/cmake: enable option for bundled libs
Summary: [patch] devel/cmake: enable option for bundled libs
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-11-10 12:13 UTC by Robert Schulze
Modified: 2016-11-18 20:04 UTC (History)
2 users (show)

See Also:
rs: maintainer-feedback+


Attachments
Add option PORTLIBS to Makefile and make LIB_DEPENDS depend on that (959 bytes, patch)
2016-11-10 12:13 UTC, Robert Schulze
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Schulze 2016-11-10 12:13:06 UTC
Created attachment 176854 [details]
Add option PORTLIBS to Makefile and make LIB_DEPENDS depend on that

Installing cmake due to a build dependency results in installing curl, expat, jsoncpp and python, which is simply bloated because cmake has all dependencies bundled.

This patch enables the user to decide whether the dependencies should be built from ports or from the bundled sources. The default has been left at "use system libs".
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2016-11-10 13:41:51 UTC
I'm not a fan of this. Also there is [1]. 
Are you sure, you do not need to add patches the bundled libs (for example ftp/curl has patches in ports, so why do the bundled ones don't need any?).   

The packages are: Jsoncpp is 726k, expat 481k -- not really bloaty. Ok, curl is 5M, but cmake itself is 16M. [Also I don't think python is a dependency of devel/cmake, devel/cmake-doc however uses py-sphinx].

Are you sure, you'll save any space (apart from the lines of output in 'pkg info') and unbloat it with that option?


[1] https://www.freebsd.org/doc/en/books/porters-handbook/bundled-libs.html


mfg Tobias
Comment 2 Robert Schulze 2016-11-10 13:53:56 UTC
(In reply to Tobias C. Berner from comment #1)

Well, jsoncpp depends on scons (another useless dependency) which needs Python. 

I intentionally left the defaults unchanged, so such a debate should not occur at all and my intention was not to save space but to save compilation time - I don't use packages. 

The trigger for this is the current breakage of py-setuptools which in turn won't allow me to install cmake, that is an annoying result of overloaded dependencies.

regards,
Robert Schulze
Comment 3 Robert Schulze 2016-11-10 13:59:11 UTC
Sorry, I somehow overwrote you changes on maintainer-feedback.
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2016-11-18 20:04:33 UTC
Hi. 

I'll close this as 'rejected'. This is a rabbit hole I do not want to go down :) -- I hope you understand.


mfg Tobias