Bug 214408 - dns/powerdns: Fix compilation on FreeBSD 9.3 and a pgsql backend memleak
Summary: dns/powerdns: Fix compilation on FreeBSD 9.3 and a pgsql backend memleak
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Torsten Zuehlsdorff
URL:
Keywords: easy
Depends on:
Blocks: 211147
  Show dependency tree / graph
 
Reported: 2016-11-10 20:43 UTC by Ralf van der Enden
Modified: 2017-01-17 15:41 UTC (History)
2 users (show)

See Also:
koobs: merge-quarterly?

Attachments
fix build on freebsd 9.3 and plug a memleak (2.59 KB, patch)
2016-11-10 20:43 UTC, Ralf van der Enden 		tremere: maintainer-approval+
Details | Diff
Fix build on 9.3 and plug a memleak (2.57 KB, patch)
2016-11-16 09:40 UTC, Ralf van der Enden 		tremere: maintainer-approval+
tremere: maintainer-approval+
Details | Diff
fix build on freebsd 9.3 and plug a memleak (2.59 KB, patch)
2016-11-25 08:13 UTC, Ralf van der Enden 		tremere: maintainer-approval+
Details | Diff
fix build on freebsd 9.3 and plug a memleak (2.68 KB, patch)
2016-11-30 11:15 UTC, Ralf van der Enden 		tremere: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf van der Enden 2016-11-10 20:43:44 UTC 
Created attachment 176871 [details]
fix build on freebsd 9.3 and plug a memleak

- Fix compilation on FreeBSD 9.3 (OpenSSL or variant required from ports)
- Plug a memleak in the pgsql backend + bump PORTREVISION

Poudriere buildlog: https://pkg.cainites.net/data/freebsd_9-3x32-system/2016-11-10_20h31m11s/logs/powerdns-4.0.1_1.log
Comment 1 Ralf van der Enden 2016-11-16 09:40:45 UTC 
Created attachment 177060 [details]
Fix build on 9.3 and plug a memleak
Comment 2 Ralf van der Enden 2016-11-16 09:42:32 UTC 
Comment on attachment 177060 [details]
Fix build on 9.3 and plug a memleak

Redo the previous patch due to the commit of a blanket patch
Comment 3 Ralf van der Enden 2016-11-25 08:13:48 UTC 
Created attachment 177371 [details]
fix build on freebsd 9.3 and plug a memleak

Redo the patch again due to devel/boost-libs upgrade, which changed the PORTREVISION
Comment 4 Ralf van der Enden 2016-11-30 11:15:59 UTC 
Created attachment 177534 [details]
fix build on freebsd 9.3 and plug a memleak

Blanket patch readded the Broken_FreeBSD at the top of the Makefile. Redo patch (yet again) to actually allow building on FreeBSD 9
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-30 11:24:30 UTC 
Thanks for the submission Ralf.

Could you please amend the conditional BROKEN_FreeBSD_9 messaging to something like:

Building on FreeBSD 9.x requires SSL from Ports. To do so set DEFAULT_VERSIONS ...

Also, if the patch comes from or has been submitted upstream, please add a comment with URL references if available to the patch header
Comment 6 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-01-06 10:13:28 UTC 
Hello,

please not that FreeBSD 9.3 is no longer supported. Can you please remove this check from the patch? I will take care of the new version.

Greetings,
Torsten
Comment 7 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-01-17 15:02:37 UTC 
The patch also did no longer apply. Can you please update it?
Comment 8 Ralf van der Enden 2017-01-17 15:41:54 UTC 
This PR has become obsolete due to the creation of new PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216136

Closing this one.