Bug 214653 - audio/playgsf: fails to build with libc++ 3.9
Summary: audio/playgsf: fails to build with libc++ 3.9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL: https://github.com/llvm-mirror/libcxx...
Keywords: easy, patch
Depends on:
Blocks: 212343
  Show dependency tree / graph
 
Reported: 2016-11-19 01:39 UTC by Jan Beich
Modified: 2016-11-24 14:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
Patch (1.61 KB, patch)
2016-11-24 13:31 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-11-19 01:39:13 UTC 
VBA/Util.cpp:920:11: error: cannot initialize a variable of type 'char *' with an rvalue of type
      'const char *'
    char *p = strrchr(file,'.');
          ^   ~~~~~~~~~~~~~~~~~
VBA/Util.cpp:937:12: error: cannot initialize a variable of type 'char *' with an rvalue of type
      'const char *'
    char * p = strrchr(file,'.');
           ^   ~~~~~~~~~~~~~~~~~

http://package18.nyi.freebsd.org/data/headi386PR212343-default/2016-09-11_07h04m19s/logs/errors/playgsf-0.7.1_2.log
http://package18.nyi.freebsd.org/data/headamd64PR212343-default/2016-09-13_07h18m01s/logs/errors/playgsf-0.7.1_2.log
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-11-24 13:31:55 UTC 
Created attachment 177355 [details]
Patch

Proposed patch. Apart from fixing const char* issue, switch to USES=localbase and add LICENSE. GPLv2+ for VBA code, LGPL21 for bundled libresample code and NONE for playgsf code, as no license is specified neither for it nor for code it's based on (http://www.caitsith2.com/gsf/)
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-11-24 14:19:20 UTC 
A commit references this bug:

Author: ehaupt
Date: Thu Nov 24 14:18:53 UTC 2016
New revision: 427013
URL: https://svnweb.freebsd.org/changeset/ports/427013

Log:
  - Fix build with libc++ 3.9
  - Switch to USES=localbase
  - Add LICENSE: GPLv2+ for VBA code, LGPL21 for bundled libresample code and
    NONE for playgsf code, as no license is specified neither for it nor for
    code it's based on (http://www.caitsith2.com/gsf/)

  PR:		214653
  Submitted by:	amdmi3
  Reported by:	jbeich

Changes:
  head/audio/playgsf/Makefile
  head/audio/playgsf/files/patch-VBA_Util.cpp