Bug 214684 - science/paraview: Update to 5.2.0
Summary: science/paraview: Update to 5.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-20 05:24 UTC by Yuri Victorovich
Modified: 2017-01-10 13:09 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (devel)
devel: maintainer-feedback+


Attachments
patch (138.55 KB, patch)
2016-11-20 05:24 UTC, Yuri Victorovich
no flags Details | Diff
patch (138.40 KB, patch)
2016-11-20 05:25 UTC, Yuri Victorovich
no flags Details | Diff
Patch for fix build in 9.3-RELEASE (595 bytes, patch)
2016-12-02 07:45 UTC, devel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2016-11-20 05:24:40 UTC
Created attachment 177199 [details]
patch

Passes poudriere on 11amd64.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2016-11-20 05:25:29 UTC
Created attachment 177200 [details]
patch
Comment 2 devel 2016-12-02 07:45:50 UTC
Created attachment 177591 [details]
Patch for fix build in 9.3-RELEASE

I have error while
[ 55%] Building CXX object ParaViewCore/ServerManager/Core/CMakeFiles/vtkPVServerManagerCore.dir/vtkSMCoreUtilities.cxx.o
...
/usr/ports/WORK/usr/ports/science/paraview/work/ParaView-v5.2.0/ParaViewCore/ServerManager/Core/vtkSMCoreUtilities.cxx: In function 'bool<unnamed>::AdjustTRange(T*, EquivSizeIntT) [with T = double, EquivSizeIntT = long long int]':
/usr/ports/WORK/usr/ports/science/paraview/work/ParaView-v5.2.0/ParaViewCore/ServerManager/Core/vtkSMCoreUtilities.cxx:237:   instantiated from here
/usr/ports/WORK/usr/ports/science/paraview/work/ParaView-v5.2.0/ParaViewCore/ServerManager/Core/vtkSMCoreUtilities.cxx:193: error: call of overloaded 'abs(long long int)' is ambiguous
/usr/include/stdlib.h:83: note: candidates are: int abs(int)
/usr/include/c++/4.2/cstdlib:143: note:                 long int std::abs(long int)
/usr/include/c++/4.2/cmath:89: note:                 double std::abs(double)
/usr/include/c++/4.2/cmath:93: note:                 float std::abs(float)
/usr/include/c++/4.2/cmath:97: note:                 long double std::abs(long double)



And fix it by patch.
Is it OK in other enviroment ?
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2016-12-02 07:50:09 UTC
C++ is broken in 9, and it is going to be retied in 30 days.
I only ran it on 11.
Comment 4 devel 2016-12-02 08:35:31 UTC
Ok, lets's commit your variant.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-01-10 10:59:14 UTC
A commit references this bug:

Author: wen
Date: Tue Jan 10 10:59:02 UTC 2017
New revision: 431074
URL: https://svnweb.freebsd.org/changeset/ports/431074

Log:
  - Update to 5.2.0

  PR:		214684
  Submitted by:	yuri@rawbw.com
  Approved by:	maintainer

Changes:
  head/science/paraview/Makefile
  head/science/paraview/distinfo
  head/science/paraview/files/patch-ParaViewCore_ClientServerCore_Default_vtkPVFileInformation.h
  head/science/paraview/files/patch-Plugins_CDIReader_cdilib.c
  head/science/paraview/files/patch-Plugins_PointSprite_CMakeLists.txt
  head/science/paraview/files/patch-Plugins_PointSprite_ParaViewPlugin_CMakeLists.txt
  head/science/paraview/files/patch-VTK_GUISupport_Qt_CMakeLists.txt
  head/science/paraview/files/patch-VTK_Rendering_FreeType_vtkFreeTypeTools.cxx
  head/science/paraview/pkg-plist