Bug 214745 - x11/swarp: Take MAINTAINER'ship (unmaintained port)
Summary: x11/swarp: Take MAINTAINER'ship (unmaintained port)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Torsten Zuehlsdorff
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2016-11-22 15:46 UTC by Mason Loring Bliss
Modified: 2016-11-23 15:46 UTC (History)
1 user (show)

See Also:


Attachments
MAINTAINER assignment (367 bytes, patch)
2016-11-22 16:41 UTC, Mason Loring Bliss
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mason Loring Bliss freebsd_triage 2016-11-22 15:46:28 UTC
I installed x11/swarp last night on a new install of FreeBSD 11, and I saw
this message:

    The swarp port currently does not have a maintainer. As a result, it is
    more likely to have unresolved issues, not be up-to-date, or even be
    removed in the future. To volunteer to maintain this port, please create
    an issue at:

        https://bugs.freebsd.org/bugzilla

With this in mind, I'd like to volunteer to maintain it, and potentially other
suckless.org ports if they end up needing a maintainer. I've been wanting to
contribute code to FreeBSD and this seems like a good way to start. I've been
slowly reading through the latest daemon book, and lately I've been spinning
up more FreeBSD instances and hardware.

I already do a tiny bit of stuff on the wiki, and I suspect that Kubilay Kocak
would vouch for me. Deb Goodkin from the Foundation might also vouch for my
character.

I've got a modicum of software engineering experience, having had a couple
pure development jobs in my career, and FreeBSD is one of my primary platforms
at present.

If I could request a particular address, I'd like to be mason@freebsd.org. I
can be reached at mason@blisses.org to coordinate things.

Thanks!
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2016-11-22 16:14:01 UTC
Thanks for volunteering.  Please be sure you've checked out the following for an introduction:

https://www.freebsd.org/doc/en_US.ISO8859-1/articles/contributing/ports-contributing.html

That also contains a URL to the Porter's Handbook.  Don't worry, it's not necessary to understand everything in it -- no one does :-)

I do have to add the @FreeBSD.org addresses are reserved for committers in most circumstances.  I was going to point to where it says that in our documentation but a quick glance doesn't find it.  It's one of the few perks :-)
Comment 2 Mason Loring Bliss freebsd_triage 2016-11-22 16:39:55 UTC
Ah, would I not be committing, then, but just emailing in patches? I hadn't realized. I see it now, though.

I'll work my way up to being a committer, then, I guess.

Can we use this ticket for the MAINTAINER-change patch? I'll open a separate ticket if that's prefereable.
Comment 3 Mason Loring Bliss freebsd_triage 2016-11-22 16:41:13 UTC
Created attachment 177288 [details]
MAINTAINER assignment
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-11-23 02:13:15 UTC
Comment on attachment 177288 [details]
MAINTAINER assignment

Unmaintained port, implicit approval
Comment 5 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-11-23 15:31:22 UTC
Aloha Mason,

how did you create the patch? I was not able to apply it. Since its so easy i just did change the MAINTAINER by myself. ;)

The best way to create a patch is "svn diff" which than can applied by "svn patch".

Greetings,
Torsten
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-11-23 15:34:19 UTC
A commit references this bug:

Author: tz
Date: Wed Nov 23 15:33:32 UTC 2016
New revision: 426939
URL: https://svnweb.freebsd.org/changeset/ports/426939

Log:
  x11/swarp: Pass maintainership to Mason Loring Bliss

  PR:           214745
  Submitted by: Mason Loring Bliss <mason@blisses.org>
  Approved by:  mentors (implicit)

Changes:
  head/x11/swarp/Makefile
Comment 7 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-11-23 15:37:48 UTC
Committed, thanks for taking care of this port!
Comment 8 Mason Loring Bliss freebsd_triage 2016-11-23 15:41:02 UTC
I'm curious about this now. That was how I created it... I made the change
after svn switch'ing to head (was quarterly previously) and then:

root@postoffice:/usr/ports/x11/swarp # svnlite diff
Index: Makefile
===================================================================
--- Makefile    (revision 426832)
+++ Makefile    (working copy)
@@ -7,7 +7,7 @@
 CATEGORIES=    x11
 MASTER_SITES=  http://dl.suckless.org/tools/

-MAINTAINER=    ports@FreeBSD.org
+MAINTAINER=    mason@blisses.org
 COMMENT=       X11 generic pointer warping utility

 LICENSE=       MIT
root@postoffice:/usr/ports/x11/swarp #


Maybe there was a whitespace issue, as I *did* naughtily cut and paste that
rather than dumping it into a file.

I just installed the full Subversion on that box, and the output format is
identical. I'm going to blame whitespace unless I learn differently!

Anyway, thank you for changing this! I'm going to hunt down a few more and
open tickets to chown them. I had no clue until last night that so many have
been orphaned.
Comment 9 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2016-11-23 15:46:15 UTC
Lets blame whitespace and just dump the next diff into a file. Copying often destroys the invisible but important chars. ;)

You are welcome to adopt more ports. I'm looking forward! :)