Bug 214978 - www/firefox: update firefox and friends to 50.0.2/45.5.1
Summary: www/firefox: update firefox and friends to 50.0.2/45.5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko mailing list
URL: https://www.mozilla.org/en-US/securit...
Keywords: easy, patch, patch-ready, security
Depends on:
Blocks:
 
Reported: 2016-12-01 12:52 UTC by Christoph Moench-Tegeder
Modified: 2016-12-02 19:45 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments
vuln.xml fragment (1.30 KB, text/plain)
2016-12-01 12:52 UTC, Christoph Moench-Tegeder
no flags Details
update firefox and thunderbird ports (70.24 KB, patch)
2016-12-01 12:55 UTC, Christoph Moench-Tegeder
no flags Details | Diff
update firefox and thunderbird ports - take 2 (70.40 KB, patch)
2016-12-01 13:09 UTC, Christoph Moench-Tegeder
no flags Details | Diff
update firefox, libxul and thunderbird (71.40 KB, patch)
2016-12-01 13:12 UTC, Christoph Moench-Tegeder
jbeich: maintainer-approval+
Details | Diff
vuxml fragment (1.39 KB, text/plain)
2016-12-01 13:14 UTC, Christoph Moench-Tegeder
jbeich: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer 2016-12-01 12:52:38 UTC
Created attachment 177570 [details]
vuln.xml fragment

Mozilla released a security fix release yesterday.
Attached: vuxml fragment
Comment 1 Christoph Moench-Tegeder freebsd_committer 2016-12-01 12:55:18 UTC
Created attachment 177571 [details]
update firefox and thunderbird ports
Comment 2 Jochen Neumeister freebsd_committer 2016-12-01 12:59:44 UTC
Hi Christop,

an update from 50.0.1 to 50.0.2 stop here with this error:

====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
Warning: Bad symlink '/usr/local/share/pixmaps/firefox.png' pointing to an absolute pathname '/usr/local/lib/firefox/browser/chrome/icons/default/default48.png'
Warning: Bad symlink '/usr/local/bin/firefox' pointing to an absolute pathname '/usr/local/lib/firefox/firefox'
Error: /usr/local/lib/firefox/libxul.so is linked to /usr/local/lib/libxcb-shm.so.0 from x11/libxcb but it is not declared as a dependency
Warning: you need USE_XORG+=xcb
Error: /usr/local/lib/firefox/libxul.so is linked to /usr/local/lib/libxcb.so.1 from x11/libxcb but it is not declared as a dependency
Warning: you need USE_XORG+=xcb
===>  Testing for firefox-50.0.2,1

uname -a
FreeBSD phantomias.home.xxxxx 11.0-RELEASE-p2 FreeBSD 11.0-RELEASE-p2 #0: Mon Oct 24 06:55:27 UTC 2016     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
Comment 3 Jan Beich freebsd_committer 2016-12-01 13:09:30 UTC
Comment on attachment 177570 [details]
vuln.xml fragment

www/libxul is also affected.
Comment 4 Christoph Moench-Tegeder freebsd_committer 2016-12-01 13:09:38 UTC
Created attachment 177572 [details]
update firefox and thunderbird ports - take 2

poudriere/stage-qa complained about a missing dependency on xcb - adding that.
That seems to be new here...
Comment 5 Christoph Moench-Tegeder freebsd_committer 2016-12-01 13:12:49 UTC
Created attachment 177573 [details]
update firefox, libxul and thunderbird

drats, libxul, completely forgot about that one... here it is (poudriere will take a moment)
Comment 6 Christoph Moench-Tegeder freebsd_committer 2016-12-01 13:14:19 UTC
Created attachment 177574 [details]
vuxml fragment

added libxul here, too
Comment 7 Jochen Neumeister freebsd_committer 2016-12-01 13:21:57 UTC
(In reply to Christoph Moench-Tegeder from comment #5)

update works fine with USE_XORG+= xcb:
===>  Cleaning for firefox-50.0.2,1

starting build in poudriere, too (builder.miwibox.org)
Comment 8 Christoph Moench-Tegeder freebsd_committer 2016-12-01 13:31:35 UTC
(In reply to Jochen Neumeister from comment #7)

Except it doesn't, we need:

Index: Mk/bsd.gecko.mk
===================================================================
--- Mk/bsd.gecko.mk     (revision 427484)
+++ Mk/bsd.gecko.mk     (working copy)
@@ -89,7 +89,7 @@
                        python:2.7,build desktop-file-utils
 CPE_VENDOR?=mozilla
 USE_PERL5=     build
-USE_XORG=      x11 xcomposite xdamage xext xfixes xrender xt
+USE_XORG+=     x11 xcomposite xdamage xext xfixes xrender xt
 
 .if ${MOZILLA} != "libxul"
 BUNDLE_LIBS=   yes

else bsd.gecko.mk just overwrites USE_XORG in the port's Makefile.
Comment 9 Jan Beich freebsd_committer 2016-12-01 13:33:30 UTC
Comment on attachment 177573 [details]
update firefox, libxul and thunderbird

Approved except for the following

(In reply to Christoph Moench-Tegeder from comment #4)
> poudriere/stage-qa complained about a missing dependency on xcb - adding that.

https://bugzilla.mozilla.org/show_bug.cgi?id=1286649 landed in Firefox 50.

> +++ www/firefox/Makefile	(working copy)
[...]
>  USE_GL=		gl
> +USE_XORG+=	xcb

Add to Mk/bsd.gecko.mk under MOZILLA_VER conditional instead, otherwise it won't have an effect.
Comment 10 commit-hook freebsd_committer 2016-12-01 13:41:18 UTC
A commit references this bug:

Author: cmt
Date: Thu Dec  1 13:40:51 UTC 2016
New revision: 427499
URL: https://svnweb.freebsd.org/changeset/ports/427499

Log:
  document mozilla vulnerabilities CVE-2016-9079

  PR:		214978
  Approved by:	jbeich, rene (mentor, implicit)

Changes:
  head/security/vuxml/vuln.xml
Comment 11 commit-hook freebsd_committer 2016-12-01 14:24:58 UTC
A commit references this bug:

Author: cmt
Date: Thu Dec  1 14:24:19 UTC 2016
New revision: 427504
URL: https://svnweb.freebsd.org/changeset/ports/427504

Log:
  update firefox 50.0.2, libxul and thunderbird 45.5.1

  PR:		214978
  Approved by:	jbeich (maintainer), rene (mentor, implicit)
  MFH:		2016Q4
  Security:	18f39fb6-7400-4063-acaf-0806e92c094f

Changes:
  head/Mk/bsd.gecko.mk
  head/mail/linux-thunderbird/Makefile
  head/mail/linux-thunderbird/distinfo
  head/mail/thunderbird/Makefile
  head/mail/thunderbird/distinfo
  head/mail/thunderbird-i18n/Makefile
  head/mail/thunderbird-i18n/distinfo
  head/www/firefox/Makefile
  head/www/firefox/distinfo
  head/www/firefox-esr/Makefile
  head/www/firefox-esr/distinfo
  head/www/firefox-esr-i18n/Makefile
  head/www/firefox-esr-i18n/distinfo
  head/www/firefox-i18n/Makefile
  head/www/firefox-i18n/distinfo
  head/www/libxul/Makefile
  head/www/libxul/distinfo
  head/www/linux-firefox/Makefile
  head/www/linux-firefox/distinfo
Comment 12 Christoph Moench-Tegeder freebsd_committer 2016-12-01 15:02:12 UTC
committed ports r427504
Comment 13 Gary 2016-12-01 16:03:43 UTC
my poudriere build failed for www/firefox-esr-i18n as there are a number of languages in www/firefox-esr-i18n/Makefile.lang that aren't in www/firefox-esr-i18n/distinfo
Comment 14 commit-hook freebsd_committer 2016-12-01 16:38:04 UTC
A commit references this bug:

Author: cmt
Date: Thu Dec  1 16:37:56 UTC 2016
New revision: 427506
URL: https://svnweb.freebsd.org/changeset/ports/427506

Log:
  firefox-{,esr}-i18n: fix distinfo.

  my bad.

  PR:		214978
  Reported by:	Gary
  Approved by:	rene (implicit, mentor), fixing-my-own-mess
  MFH:		2016Q4

Changes:
  head/www/firefox-esr-i18n/distinfo
  head/www/firefox-i18n/distinfo
Comment 15 Christoph Moench-Tegeder freebsd_committer 2016-12-01 16:39:04 UTC
(In reply to Gary from comment #13)
my bad, sorry. fixed.
Comment 16 Gary 2016-12-01 16:55:32 UTC
thanks, my build works now
Comment 17 commit-hook freebsd_committer 2016-12-02 19:44:18 UTC
A commit references this bug:

Author: cmt
Date: Fri Dec  2 19:43:26 UTC 2016
New revision: 427583
URL: https://svnweb.freebsd.org/changeset/ports/427583

Log:
  MFH: r427504 r427506

  update firefox 50.0.2, libxul and thunderbird 45.5.1

  PR:		214978
  Approved by:	jbeich (maintainer), rene (mentor, implicit)
  Security:	18f39fb6-7400-4063-acaf-0806e92c094f

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/Mk/bsd.gecko.mk
  branches/2016Q4/mail/linux-thunderbird/Makefile
  branches/2016Q4/mail/linux-thunderbird/distinfo
  branches/2016Q4/mail/thunderbird/Makefile
  branches/2016Q4/mail/thunderbird/distinfo
  branches/2016Q4/mail/thunderbird-i18n/Makefile
  branches/2016Q4/mail/thunderbird-i18n/distinfo
  branches/2016Q4/www/firefox/Makefile
  branches/2016Q4/www/firefox/distinfo
  branches/2016Q4/www/firefox-esr/Makefile
  branches/2016Q4/www/firefox-esr/distinfo
  branches/2016Q4/www/firefox-esr-i18n/Makefile
  branches/2016Q4/www/firefox-esr-i18n/distinfo
  branches/2016Q4/www/firefox-i18n/Makefile
  branches/2016Q4/www/firefox-i18n/distinfo
  branches/2016Q4/www/libxul/Makefile
  branches/2016Q4/www/libxul/distinfo
  branches/2016Q4/www/linux-firefox/Makefile
  branches/2016Q4/www/linux-firefox/distinfo