Bug 215040 - devel/gflags: gflags_completions.sh kills bash if bash-completion is used
Summary: devel/gflags: gflags_completions.sh kills bash if bash-completion is used
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-04 10:14 UTC by Ting-Wei Lan
Modified: 2016-12-05 13:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2016-12-04 10:14:03 UTC
gflags_completions.sh is not intended to be loaded into an interactive bash process. Please don't move it into ${PREFIX}/etc/bash_completion.d. It causes bash to exit when bash-completion is loaded. If users use bash as login shell and load bash-completion in ~/.bashrc or ~/.bash_login, it will cause them to fail to login.

$ . /path/to/gflags_completions.sh 
bash: -1: bad substitution
<bash process exited>
Comment 1 commit-hook freebsd_committer 2016-12-05 13:40:18 UTC
A commit references this bug:

Author: sunpoet
Date: Mon Dec  5 13:39:19 UTC 2016
New revision: 427882
URL: https://svnweb.freebsd.org/changeset/ports/427882

Log:
  - Revert r427239
  - Bump PORTREVISION for package change

  PR:		215040
  Reported by:	Ting-Wei Lan <lantw44@gmail.com>

Changes:
  head/devel/gflags/Makefile
  head/devel/gflags/pkg-plist
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2016-12-05 13:55:06 UTC
Committed. Thanks!