Bug 215203 - ports-mgmt/portlint: Add CMAKE_BOOL to options helpers list
Summary: ports-mgmt/portlint: Add CMAKE_BOOL to options helpers list
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-10 22:34 UTC by Dmitri Goutnik
Modified: 2016-12-23 23:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
patch (367 bytes, patch)
2016-12-10 22:34 UTC, Dmitri Goutnik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Goutnik freebsd_committer 2016-12-10 22:34:53 UTC
Created attachment 177858 [details]
patch

CMAKE_BOOL and CMAKE_BOOL_OFF was added in 417497 [1] and 417532 [2], attached patch adds these options to options helper list to fix false positives like

WARN: Makefile: OPT is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MOPT appears.

when OPT_CMAKE_BOOL or OPT_CMAKE_BOOL_OFF is used.

[1] https://svnweb.freebsd.org/ports/head/Mk/bsd.options.mk?r1=414547&r2=417497
[2] https://svnweb.freebsd.org/ports/head/Mk/bsd.options.mk?r1=417497&r2=417532
Comment 1 Joe Marcus Clarke freebsd_committer 2016-12-23 23:20:28 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2016-12-23 23:20:37 UTC
A commit references this bug:

Author: marcus
Date: Fri Dec 23 23:19:41 UTC 2016
New revision: 429292
URL: https://svnweb.freebsd.org/changeset/ports/429292

Log:
  Update to 2.17.6.

  Add support for CMAKE_BOOL

  PR:		215203
  Submitted by:	Dmitri Goutnik <dg@syrec.org>

Changes:
  head/ports-mgmt/portlint/Makefile
  head/ports-mgmt/portlint/src/portlint.pl