Bug 215273 - databases/py-sqlalchemy-migrate: Missing sqlparse dependency breaks devel/buildbot
Summary: databases/py-sqlalchemy-migrate: Missing sqlparse dependency breaks devel/bui...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2016-12-13 09:42 UTC by Nikola Kolev
Modified: 2016-12-13 11:59 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Kolev 2016-12-13 09:42:29 UTC
# pkg install buildbot
...
# buildbot create-master
Traceback (most recent call last):
  File "/usr/local/bin/buildbot", line 4, in <module>
    runner.run()
  File "/usr/local/lib/python2.7/site-packages/buildbot/scripts/runner.py", line 762, in run
    subcommandFunction = reflect.namedObject(subconfig.subcommandFunction)
  File "/usr/local/lib/python2.7/site-packages/twisted/python/reflect.py", line 168, in namedObject
    module = namedModule('.'.join(classSplit[:-1]))
  File "/usr/local/lib/python2.7/site-packages/twisted/python/reflect.py", line 154, in namedModule
    topLevel = __import__(name)
  File "/usr/local/lib/python2.7/site-packages/buildbot/scripts/create_master.py", line 23, in <module>
    from buildbot.db import connector
  File "/usr/local/lib/python2.7/site-packages/buildbot/db/connector.py", line 25, in <module>
    from buildbot.db import model
  File "/usr/local/lib/python2.7/site-packages/buildbot/db/model.py", line 17, in <module>
    import migrate.versioning.repository
  File "/usr/local/lib/python2.7/site-packages/migrate/versioning/repository.py", line 13, in <module>
    from migrate.versioning import version, pathed, cfgparse
  File "/usr/local/lib/python2.7/site-packages/migrate/versioning/version.py", line 10, in <module>
    from migrate.versioning import pathed, script
  File "/usr/local/lib/python2.7/site-packages/migrate/versioning/script/__init__.py", line 6, in <module>
    from migrate.versioning.script.sql import SqlScript
  File "/usr/local/lib/python2.7/site-packages/migrate/versioning/script/sql.py", line 7, in <module>
    import sqlparse
ImportError: No module named sqlparse

# pkg install py27-sqlparse
# buildbot create-master
updating existing installation
creating /usr/home/buildbot/master.cfg.sample
populating public_html/
populating templates/
creating database (sqlite:///state.sqlite)
buildmaster configured in /usr/home/buildbot

py-sqlparse should be added to RUN_DEPENDS.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-12-13 10:56:20 UTC
Thanks for the report Nikola, not sure how this was missed.

Will take care of the fix (and merge) shortly.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-12-13 11:19:39 UTC
This is actually a bug in the databases/py-sqlalchemy-migrate port, which is missing the sqlparse dependency, though it is included/mentioned in requirements.txt (and unfortunately not in setup.py, because it uses pbr)

'six' is also missing.

I'll take care of the commit
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-12-13 11:47:37 UTC
A commit references this bug:

Author: koobs
Date: Tue Dec 13 11:46:47 UTC 2016
New revision: 428480
URL: https://svnweb.freebsd.org/changeset/ports/428480

Log:
  databases/py-sqlalchemy-migrate: Add sqlparse and six dependencies

  Both sqlparse and six are mentioned as dependencies, but are missing in
  the ports RUN_DEPENDS.

  The missing sqlparse dependencies causes (at least) devel/buildbot to
  generate an error at run-time [1].

  This change adds sqlparse and six to RUN_DEPENDS.

  While I'm here:

  - Add LICENSE_FILE
  - Update RUN_DEPENDS version specs to match upstream files (NOOP)
  - Enable "concurrent" Python version installation
  - Add NO_ARCH (architecture independent)

  PR:		215273 [1]
  Reported by:	Nikola Kolev <koue chaosophia net>
  Approved by:	portmgr (blanket)
  MFH:		2016Q4

Changes:
  head/databases/py-sqlalchemy-migrate/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-12-13 11:58:48 UTC
A commit references this bug:

Author: koobs
Date: Tue Dec 13 11:58:15 UTC 2016
New revision: 428481
URL: https://svnweb.freebsd.org/changeset/ports/428481

Log:
  MFH: r428480 databases/py-sqlalchemy-migrate: Add sqlparse and six dependencies

  Both sqlparse and six are mentioned as dependencies, but are missing in
  the ports RUN_DEPENDS.

  The missing sqlparse dependencies causes (at least) devel/buildbot to
  generate an error at run-time [1].

  This change adds sqlparse and six to RUN_DEPENDS.

  While I'm here:

  - Add LICENSE_FILE
  - Update RUN_DEPENDS version specs to match upstream files (NOOP)
  - Enable "concurrent" Python version installation
  - Add NO_ARCH (architecture independent)

  PR:		215273 [1]
  Reported by:	Nikola Kolev <koue chaosophia net>
  Approved by:	portmgr (blanket)

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/databases/py-sqlalchemy-migrate/Makefile
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-12-13 11:59:34 UTC
Committed and merged to quarterly (2016Q4) with additional changes/improvements.

Thank you Nikola!