Bug 215293 - net-mgmt/seafile-server: Cloned port from net-mgmt/seafile
Summary: net-mgmt/seafile-server: Cloned port from net-mgmt/seafile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL: https://github.com/haiwen/seafile-server
Keywords: patch-ready
Depends on: 215292
Blocks: 215294
  Show dependency treegraph
 
Reported: 2016-12-14 03:48 UTC by Ultima
Modified: 2016-12-26 13:00 UTC (History)
2 users (show)

See Also:


Attachments
seafile-server.diff (44.45 KB, patch)
2016-12-14 03:48 UTC, Ultima
Ultima1252: maintainer-approval+
Details | Diff
seafile-server.diff (42.68 KB, patch)
2016-12-25 23:41 UTC, Ultima
Ultima1252: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ultima 2016-12-14 03:48:37 UTC
Created attachment 177955 [details]
seafile-server.diff

This is a new port that was cloned from net-mgmt/seafile with one added, and regenerated patch files and updated pkg-desc / comment as well as some fixes to rc script. Why was this cloned? Seafile decided to split the client and server repos thus why a cloned port was created.

testing: I have tested the update proccess from 6.0.0 --> 6.0.4 (seahub and ccnet/seafile depends) and went smooth. I'v also created a fresh jail and created a fresh install and worked as expected.     More testing always welcome of course.

pkg-desc:
Seafile is an open source cloud storage system with features on privacy
protection and teamwork. Collections of files are called libraries, and
each library can be synced separately. A library can also be encrypted
with a user chosen password. Seafile also allows users to create groups
and easily sharing files into groups.

This is the core component of Seafile server. It provides RPC to the web
front-end (Seahub) to access files, and provides HTTP APIs to the desktop
clients for syncing files.

WWW: https://github.com/haiwen/seafile-server

portlint -AC:
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
0 fatal errors and 1 warnings found.

poudriere bulk -tC:
12amd64: success
12i386: success
110amd64: success
110i386: success
103amd64: success
103i386: success
93amd64: skipped: py27-cryptography-1.6: compiler_error
93i386: skipped: py27-cryptography-1.6: compiler_error
Comment 1 Thomas Zander freebsd_committer 2016-12-17 16:54:50 UTC
Just to be clear, do you want to retire net-mgmt/seafile and have net-mgmt/seafile-server instead?
Comment 2 Ultima 2016-12-17 18:40:13 UTC
(In reply to Thomas Zander from comment #1)
 The netmgmt/ccnet and netmgmt/seafile port will turn into a client ports. Have an update that i'm currently testing. If they all is well during the tests, will be posted with the bug #215294 as a depend.


 The reason they are being cloned instead of modified and/or changed at the same time is to prevent breakage due to upgrading between the several revisions coming. I hope this sounds more logical.
Comment 3 Thomas Zander freebsd_committer 2016-12-25 17:33:57 UTC
(In reply to Ultima from comment #2)

What is files/tags used for? Seems like a leftover file from your testing.
Comment 4 Thomas Zander freebsd_committer 2016-12-25 17:54:17 UTC
(In reply to Ultima from comment #2)

Could you double-check regarding these findings from poudriere?

====> Running Q/A tests (stage-qa)
Warning: Bad symlink '/usr/local/bin/seafile-controller' pointing to an absolute pathname '/usr/local/www/haiwen/seafile-server/seafile/bin/seafile-controller'
Warning: Bad symlink '/usr/local/bin/seaf-server' pointing to an absolute pathname '/usr/local/www/haiwen/seafile-server/seafile/bin/seaf-server'
Error: /usr/local/www/haiwen/seafile-server/seafile/bin/seaf-server is linked to /usr/local/lib/libiconv.so.2 from converters/libiconv but it is not declared as a dependency
Warning: you need USES+=iconv
Comment 5 Ultima 2016-12-25 23:41:39 UTC
Created attachment 178274 [details]
seafile-server.diff

(In reply to Thomas Zander from comment #4)
 Ah, it is a vim plugin that generates that file. It has been removed. Also, I'v noticed that the ccnet-server diff was missing SUBDIR in CAT/makefile. This was added.

 The warnings in poudriere log are probably bugs. It is checking the systems absolute path instead of the stagedir path. Because it is not yet installed it detects that the file doesn't exist. Unless the warning is actually suggesting to not use absolute paths for the link? I haven't looked to deeply into it but the symlinks work on an installed system.

# ls -l /usr/local/bin/seafile-controller 
lrwxr-xr-x  1 root  wheel  67 Dec 11 23:17 /usr/local/bin/seafile-controller -> /usr/local/www/haiwen/seafile-server/seafile/bin/seafile-controller
# /usr/local/bin/seafile-controller 
Usage: seafile-controller OPTIONS
OPTIONS:
  -b, --bin-dir           insert a directory in front of the PATH env
  -c, --config-dir        ccnet config dir
  -d, --seafile-dir       seafile dir

# ls -l /usr/local/bin/seaf-server
lrwxr-xr-x  1 root  wheel  60 Dec 11 23:17 /usr/local/bin/seaf-server -> /usr/local/www/haiwen/seafile-server/seafile/bin/seaf-server
# /usr/local/bin/seaf-server -VV
seaf-server: invalid option -- V



As for iconv, it is in the USES but still generates the error.
Comment 6 Thomas Zander freebsd_committer 2016-12-26 09:06:54 UTC
(In reply to Ultima from comment #5)

> Unless the warning is actually suggesting to not use absolute paths for the link? I haven't looked to deeply into it but the symlinks work on an installed system.

In general, symlinks to absolute locations should be avoided. Sometimes it is necessary, but if there is a reasonably easy way to get around it, we should avoid it. Just wanted to ensure they are really necessary in this case.
Comment 7 commit-hook freebsd_committer 2016-12-26 12:55:52 UTC
A commit references this bug:

Author: riggs
Date: Mon Dec 26 12:55:11 UTC 2016
New revision: 429506
URL: https://svnweb.freebsd.org/changeset/ports/429506

Log:
  Prepare split of net-mgmt/seafile in client / server ports; update to 6.0.6

  PR:		215293
  Submitted by:	Ultima1252@gmail.com (maintainer)

Changes:
  head/net-mgmt/Makefile
  head/net-mgmt/seafile-server/
  head/net-mgmt/seafile-server/Makefile
  head/net-mgmt/seafile-server/distinfo
  head/net-mgmt/seafile-server/files/patch-common_obj-backend-fs.c
  head/net-mgmt/seafile-server/files/patch-configure.ac
  head/net-mgmt/seafile-server/files/patch-controller_seafile-controller.c
  head/net-mgmt/seafile-server/files/patch-daemon_Makefile.am
  head/net-mgmt/seafile-server/files/patch-daemon_http-tx-mgr.c
  head/net-mgmt/seafile-server/files/patch-daemon_repo-mgr.c
  head/net-mgmt/seafile-server/files/patch-daemon_vc-utils.c
  head/net-mgmt/seafile-server/files/patch-lib_Makefile.am
  head/net-mgmt/seafile-server/files/patch-lib_net.c
  head/net-mgmt/seafile-server/files/patch-lib_utils.c
  head/net-mgmt/seafile-server/files/patch-lib_utils.h
  head/net-mgmt/seafile-server/files/patch-scripts_setup-seafile.sh
  head/net-mgmt/seafile-server/files/patch-scripts_upgrade_regenerate__secret__key.sh
  head/net-mgmt/seafile-server/files/patch-server_access-file.c
  head/net-mgmt/seafile-server/files/seafile.in
  head/net-mgmt/seafile-server/pkg-descr
  head/net-mgmt/seafile-server/pkg-plist
Comment 8 commit-hook freebsd_committer 2016-12-26 12:58:01 UTC
A commit references this bug:

Author: riggs
Date: Mon Dec 26 12:57:21 UTC 2016
New revision: 429510
URL: https://svnweb.freebsd.org/changeset/ports/429510

Log:
  Register CONFLICTS for seafile-server; bump PORTREVISION

  PR:		215293
  Submitted by:	Ultima1252@gmail.com (maintainer)

Changes:
  head/net-mgmt/seafile/Makefile