Created attachment 178015 [details] complete lightning restore ports r428672 removed enigmail and lightning, and ports r428676 should have broght lightning back (at least, that's what I gathered from the commit message). While it restored the LIGHTNING option, it failed to restore the post-install and other vital parts of the lightning build. Note: this also reverts ports r428681 - the XPI_DIR variable is used in the post-install target. Built, used, poudriere tested (10.3), looks ok.
Created attachment 178018 [details] thunderbird-45.5.1_1 screenshot Any reason to package Lightning extension twice (vendor + port)? https://bugzilla.mozilla.org/show_bug.cgi?id=1130854
Hm. drats. Further analysis on my existing thunderbird profile shows it picked "the wrong" lightning extension back then - the one which was removed and which I brough back in addition to "the right one". Moreover, it looks about impossible (at least, unsupported) to swap out the lightning extension in an existing profile or just make thunderbird acknowledge that there is in fact a lightning extension. With the _6 package as currently in the ports tree I cannot use lightning in my existing profile, and the _7 version as of the attached patch shows two lightning extensions in a new profile (see Jan's screenshot, confirmed here) but at least lets me use lightning in my existing profile. I have to confess that both options are not entirely desirable.
If with thunderbird-45.5.1_6 installed I do # cd /usr/local/lib/thunderbird/extensions # ln -s ../distribution/extensions/\{e2fda1a4-762b-4020-b5ad-a41df1933103\} then lightning works again. It seems that thunderbird does not look for extensions in /usr/local/lib/thunderbird/distribution/extensions, but only in /usr/local/lib/thunderbird/extensions If I then remove the symlink again, the extension is also gone. -- Martin
Created attachment 178112 [details] symlink lightning (to make it usable) Cool, thanks for the tip. Attached patch creates the symlink. This results in exactly one lightning in a new profile, and enables lightning in an (that's my) existing profile (after a one-time confirmation on startup).
Comment on attachment 178112 [details] symlink lightning (to make it usable) Maybe add a comment that copying extensions with binary components for new profiles (under HOME) isn't good idea unless they're also available on AMO (addons.mozilla.org) thus can be updated independently. If so just use ${MV} and move under post-install-LIGHTNING-on. Ditto for www/seamonkey.
I found no solution which allows old profiles to continue using lighnting, creation of new profiles with lightning and extensions requiring lightning to work at the same time. In bug #216584 I made the cut and installed an unmodified lightning in it's default location which breaks existing profiles, but at least will (hopefully) safe us from any surprise down the line.