Bug 215351 - www/webkit2-gtk3: Build stops at link of webkitcore on amd64
Summary: www/webkit2-gtk3: Build stops at link of webkitcore on amd64
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2016-12-17 00:32 UTC by Tim
Modified: 2016-12-20 00:05 UTC (History)
3 users (show)

See Also:
vlad-fbsd: maintainer-feedback? (gnome)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim 2016-12-17 00:32:53 UTC 
webkit2-gtk3 build stops at link of webkitcore on amd64 dual core 2G ram dell former vista, I will read bug id 209686 to see if I missed something.  The build takes several hours and stops at the link step.
Comment 1 Tim 2016-12-17 22:00:54 UTC 
I am a noob on this list.  I am attempting to build from source the latest webkit which I guessed was the one in the bug.  

FBSD 11 not sure if I mentioned that.  The build worked fine up until the link.  I am a c c++ coder if that helps.
Comment 2 Ting-Wei Lan 2016-12-18 14:10:07 UTC 
Can you provide your build log, or paste error messages you got? How did you build it, by using ports or other commands? What is 'the latest webkit' you want to build, 2.8.5 (ports), 2.14.2 (stable), or 2.15.2 (unstable)?
Comment 3 Tim 2016-12-19 04:33:36 UTC 
I ran the build in the ports tree by running make as root after cd to this

cd /usr/ports/www/webkit2-gtk3
make

It apparently was attempting to linke core, here is the very end of the make 
output copied from the cmd line terminal window.  There are many warnings about the same issue which you see further down.  

The messages you see below showed up on the cmdline.

...
serveral hours of building with only warnings like this

... overrides a member function but is
      not marked 'override' [-Winconsistent-missing-override]
...

/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGExternalResourcesRequired.h:48:18: note: 
      overridden virtual function is here
    virtual void setExternalResourcesRequiredBaseValue(const bool&, cons...
                 ^
Then is sits for a while while it attempts to link.

146 warnings generated.
146 warnings generated.
gmake[3]: *** [CMakeFiles/Makefile2:718: Source/WebCore/CMakeFiles/WebCore.dir/all] Killed
gmake[2]: *** [Makefile:153: all] Error 2
Error running link command: Child killed
root@v01:/usr/ports/www/webkit2-gtk3 # 


the lead up to the tail end  

/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGExternalResourcesRequired.h:49:19: note: 
      overridden virtual function is here
    virtual bool& externalResourcesRequiredBaseValue() const = 0;
                  ^
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGElementWrapperFactory.cpp:102:
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGSVGElement.h:26:
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGSVGElement.h:46:9: warning: 
      'setExternalResourcesRequiredBaseValue' 

        DECLARE_ANIMATED_BOOLEAN(ExternalResourcesRequired, externalReso...
        ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGAnimatedBoolean.h:31:64: note: 
      expanded from macro 'DECLARE_ANIMATED_BOOLEAN'
#define DECLARE_ANIMATED_BOOLEAN(UpperProperty, LowerProperty) \
                                                               ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:129:10: note: 
      expanded from macro '\
DECLARE_ANIMATED_PROPERTY'
    void set##UpperProperty##BaseValue(const PropertyType& type, const b...
         ^
<scratch space>:163:1: note: expanded from here
setExternalResourcesRequiredBaseValue
^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGExternalResourcesRequired.h:48:18: note: 
      overridden virtual function is here
    virtual void setExternalResourcesRequiredBaseValue(const bool&, cons...
                 ^
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGElementWrapperFactory.cpp:103:
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGSwitchElement.h:26:
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGSwitchElement.h:43:5: warning: 
      'localAttributeToPropertyMap' overrides a member function but is not
      marked 'override' [-Winconsistent-missing-override]
    BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGSwitchElement)
    ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:106:40: note: 
      expanded from macro 'BEGIN_DECLARE_ANIMATED_PROPERTIES'
    virtual SVGAttributeToPropertyMap& localAttributeToPropertyMap() \
                                       ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGGraphicsElement.h:66:5: note: 
      overridden virtual function is here
    BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGGraphicsElement)
    ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:106:40: note: 
      expanded from macro 'BEGIN_DECLARE_ANIMATED_PROPERTIES'
    virtual SVGAttributeToPropertyMap& localAttributeToPropertyMap() \
                                       ^
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGElementWrapperFactory.cpp:103:
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGSwitchElement.h:26:
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGSwitchElement.h:44:9: warning: 
      'externalResourcesRequiredBaseValue' overrides a member function but is
      not marked 'override' [-Winconsistent-missing-override]
        DECLARE_ANIMATED_BOOLEAN(ExternalResourcesRequired, externalReso...
        ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGAnimatedBoolean.h:31:64: note: 
      expanded from macro 'DECLARE_ANIMATED_BOOLEAN'
#define DECLARE_ANIMATED_BOOLEAN(UpperProperty, LowerProperty) \
                                                               ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:124:19: note: 
      expanded from macro '\
DECLARE_ANIMATED_PROPERTY'
    PropertyType& LowerProperty##BaseValue() const \
                  ^
<scratch space>:78:1: note: expanded from here
externalResourcesRequiredBaseValue
^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGExternalResourcesRequired.h:49:19: note: 
      overridden virtual function is here
    virtual bool& externalResourcesRequiredBaseValue() const = 0;
                  ^
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGElementWrapperFactory.cpp:103:
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGSwitchElement.h:26:
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGSwitchElement.h:44:9: warning: 
      'setExternalResourcesRequiredBaseValue' overrides a member function but is
      not marked 'override' [-Winconsistent-missing-override]
        DECLARE_ANIMATED_BOOLEAN(ExternalResourcesRequired, externalReso...
        ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGAnimatedBoolean.h:31:64: note: 
      expanded from macro 'DECLARE_ANIMATED_BOOLEAN'
#define DECLARE_ANIMATED_BOOLEAN(UpperProperty, LowerProperty) \
                                                               ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:129:10: note: 
      expanded from macro '\
DECLARE_ANIMATED_PROPERTY'
    void set##UpperProperty##BaseValue(const PropertyType& type, const b...
         ^
<scratch space>:81:1: note: expanded from here
setExternalResourcesRequiredBaseValue
^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGExternalResourcesRequired.h:48:18: note: 
      overridden virtual function is here
    virtual void setExternalResourcesRequiredBaseValue(const bool&, cons...
                 ^
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGElementWrapperFactory.cpp:104:
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGSymbolElement.h:26:
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGSymbolElement.h:49:5: warning: 
      'localAttributeToPropertyMap' overrides a member function but is not
      marked 'override' [-Winconsistent-missing-override]
    BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGSymbolElement)
    ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:106:40: note: 
      expanded from macro 'BEGIN_DECLARE_ANIMATED_PROPERTIES'
    virtual SVGAttributeToPropertyMap& localAttributeToPropertyMap() \
                                       ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGElement.h:210:5: note: 
      overridden virtual function is here
    BEGIN_DECLARE_ANIMATED_PROPERTIES(SVGElement)
    ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:106:40: note: 
      expanded from macro 'BEGIN_DECLARE_ANIMATED_PROPERTIES'
    virtual SVGAttributeToPropertyMap& localAttributeToPropertyMap() \
                                       ^
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGElementWrapperFactory.cpp:104:
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGSymbolElement.h:26:
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGSymbolElement.h:50:9: warning: 
      'externalResourcesRequiredBaseValue' overrides a member function but is
      not marked 'override' [-Winconsistent-missing-override]
        DECLARE_ANIMATED_BOOLEAN(ExternalResourcesRequired, externalReso...
        ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGAnimatedBoolean.h:31:64: note: 
      expanded from macro 'DECLARE_ANIMATED_BOOLEAN'
#define DECLARE_ANIMATED_BOOLEAN(UpperProperty, LowerProperty) \
                                                               ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:124:19: note: 
      expanded from macro '\
DECLARE_ANIMATED_PROPERTY'
    PropertyType& LowerProperty##BaseValue() const \
                  ^
<scratch space>:107:1: note: expanded from here
externalResourcesRequiredBaseValue
^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGExternalResourcesRequired.h:49:19: note: 
      overridden virtual function is here
    virtual bool& externalResourcesRequiredBaseValue() const = 0;
                  ^
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGElementWrapperFactory.cpp:104:
In file included from /usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/DerivedSources/WebCore/JSSVGSymbolElement.h:26:
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGSymbolElement.h:50:9: warning: 
      'setExternalResourcesRequiredBaseValue' overrides a member function but is
      not marked 'override' [-Winconsistent-missing-override]
        DECLARE_ANIMATED_BOOLEAN(ExternalResourcesRequired, externalReso...
        ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/SVGAnimatedBoolean.h:31:64: note: 
      expanded from macro 'DECLARE_ANIMATED_BOOLEAN'
#define DECLARE_ANIMATED_BOOLEAN(UpperProperty, LowerProperty) \
                                                               ^
/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebCore/svg/properties/SVGAnimatedPropertyMacros.h:129:10: note: 
      expanded from macro '\
DECLARE_ANIMATED_PROPERTY'
    void set##UpperProperty##BaseValue(const PropertyType& type, const b...
         ^
Comment 4 Ting-Wei Lan 2016-12-19 08:23:04 UTC 
> Error running link command: Child killed

You probably don't have enough memory to build WebKit. I think you need 4G ~ 8G to do a release build, or 8G ~ 12G to do a debug build.
Comment 5 Tim 2016-12-19 22:56:03 UTC 
Thank you for your attention to this matter!  The subject hardware has 2GB, that sounds like the right assessment.  I will keep that limitation in mind.
Comment 6 rkoberman 2016-12-20 00:05:16 UTC 
FWIW, I have never had an issue in building it with 4G. The amount of available swap may also play into the problem, though, when RAM is limited.