Bug 215421 - iasl(8) does not build reproducibly
Summary: iasl(8) does not build reproducibly
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-19 17:43 UTC by Ed Maste
Modified: 2017-01-06 18:12 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2016-12-19 17:43:14 UTC
/usr/sbin/iasl differs in successive FreeBSD buildworlds, due to embedding the date and time in the binary:

% diffoscope repro1/usr/sbin repro2/usr/sbin
--- repro1/usr/sbin
+++ repro2/usr/sbin
├── stat {}
│ @@ -1 +1 @@
│ -2177093899 7527776 drwxr-xr-x 2 emaste emaste 4294967295 3 "Dec 19 17:27:59 2016" "Dec 19 17:27:59 2016" "Dec 19 17:27:59 2016" "Dec 19 17:27:59 2016" 131072 1 0x800 repro1/usr/sbin
│ +2177093899 7527778 drwxr-xr-x 2 emaste emaste 4294967295 3 "Dec 19 17:27:59 2016" "Dec 19 17:27:59 2016" "Dec 19 17:27:59 2016" "Dec 19 17:27:59 2016" 131072 1 0x800 repro2/usr/sbin
├── iasl
│   ├── readelf --wide --hex-dump=.data {}
│   │ @@ -2150,15 +2150,15 @@
│   │    0x00733a10 b33b5000 00000000 00000000 00000000 .;P.............
│   │    0x00733a20 ca3b5000 00000000 e33b5000 00000000 .;P......;P.....
│   │    0x00733a30 f53b5000 00000000 fc3b5000 00000000 .;P......;P.....
│   │    0x00733a40 143c5000 00000000 2d3c5000 00000000 .<P.....-<P.....
│   │    0x00733a50 423c5000 00000000 5b3c5000 00000000 B<P.....[<P.....
│   │    0x00733a60 6d3c5000 00000000 7c3c5000 00000000 m<P.....|<P.....
│   │    0x00733a70 853c5000 00000000 44656320 31392032 .<P.....Dec 19 2
│   │ -  0x00733a80 30313600 31353a30 383a3432 00000000 016.15:08:42....
│   │ +  0x00733a80 30313600 31353a34 383a3132 00000000 016.15:48:12....
│   │    0x00733a90 01000000 00000000 00000000 00000000 ................
│   │    0x00733aa0 24000000 00000000 96c14600 00000000 $.........F.....
│   │    0x00733ab0 00000000 00000000 3f000000 00000000 ........?.......
│   │    0x00733ac0 00000000 00000000 00000000 00000000 ................
│   │    0x00733ad0 28000000 00000000 39c24600 00000000 (.......9.F.....
│   │    0x00733ae0 00000000 00000000 3f000000 00000000 ........?.......
│   │    0x00733af0 00000000 00000000 00000000 00000000 ................
│   ├── stat {}
│   │ @@ -1 +1 @@
│   │ -2177093899 7527777 -r-xr-xr-x 1 emaste emaste 4294967295 1264568 "Dec 19 17:27:59 2016" "Dec 19 16:40:20 2016" "Dec 19 17:27:59 2016" "Dec 19 17:27:59 2016" 131072 1073 0x800 repro1/usr/sbin/iasl
│   │ +2177093899 7527779 -r-xr-xr-x 1 emaste emaste 4294967295 1264568 "Dec 19 17:27:59 2016" "Dec 19 16:49:58 2016" "Dec 19 17:27:59 2016" "Dec 19 17:27:59 2016" 131072 1073 0x800 repro2/usr/sbin/iasl
│   ╵
╵

Proposed patch to be added.
Comment 1 Ed Maste freebsd_committer 2016-12-19 17:50:26 UTC
https://reviews.freebsd.org/D8856
Comment 2 Jung-uk Kim freebsd_committer 2017-01-06 18:07:58 UTC
I'll take it.
Comment 3 commit-hook freebsd_committer 2017-01-06 18:10:05 UTC
A commit references this bug:

Author: jkim
Date: Fri Jan  6 18:08:54 UTC 2017
New revision: 311529
URL: https://svnweb.freebsd.org/changeset/base/311529

Log:
  Remove '-vd' option to make iasl(8) reproducible.

  PR:		215421

Changes:
  head/sys/contrib/dev/acpica/compiler/aslhelp.c
  head/sys/contrib/dev/acpica/compiler/asloptions.c
Comment 4 Jung-uk Kim freebsd_committer 2017-01-06 18:12:29 UTC
'-vd' option is removed from our iasl(8).