Bug 215463 - [NEW PORT] sysutils/paladin: A simple process supervisor
Summary: [NEW PORT] sysutils/paladin: A simple process supervisor
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
Depends on:
Reported: 2016-12-21 10:26 UTC by Randy Westlund
Modified: 2017-01-13 18:58 UTC (History)
1 user (show)

See Also:

New port (3.77 KB, patch)
2016-12-21 10:26 UTC, Randy Westlund
no flags Details | Diff
Updated new port (3.80 KB, patch)
2017-01-12 07:09 UTC, Randy Westlund
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Westlund 2016-12-21 10:26:06 UTC
Created attachment 178172 [details]
New port

New port attached.
Comment 1 Raphael Kubo da Costa freebsd_committer 2017-01-09 11:35:05 UTC
I'm not very familiar with Go or how Go ports work, so here are a few generic comments:
- portlint is complaining about your COMMENT line:
  WARN: Makefile: COMMENT is not supposed to begin with 'A ', 'An ', or 'The '.
- In general, if you set LICENSE, you should also set LICENSE_FILE.
- Isn't it possible to drop your do-build target by passing the -ldflags bit in CGO_CFLAGS or CGO_LDFLAGS?
Comment 2 Randy Westlund 2017-01-12 07:09:07 UTC
Created attachment 178774 [details]
Updated new port

Thanks for taking a look.  I've fixed COMMENT and added LICENSE_FILE.

I tried using CGO_LDFLAGS before deciding to override do-build, but I couldn't get it working.  I only have a rudimentary understanding of this myself, but I'm pretty sure the -ldflags bit needs to be an argument to the Go command, rather than an environment variable.

I looked at a lot of other Go ports in the tree; overriding do-build for reasons like this seems to be pretty common.
Comment 3 commit-hook freebsd_committer 2017-01-13 18:00:11 UTC
A commit references this bug:

Author: rakuco
Date: Fri Jan 13 17:59:55 UTC 2017
New revision: 431409
URL: https://svnweb.freebsd.org/changeset/ports/431409

  New port: sysutils/paladin

  Simple process supervisor.

  WWW: https://github.com/rwestlund/paladin

  PR:		215463
  Submitted by:	Randy Westlund <rwestlun@gmail.com>

Comment 4 Raphael Kubo da Costa freebsd_committer 2017-01-13 18:01:49 UTC
Committed at last, thank you for the port!

Sidebar: while I don't have problems with new ports being sent as patch files, do note that the official procedure says they should be sent as .shar files. Keep that in mind to avoid issues with other committers in the future :-)
Comment 5 Randy Westlund 2017-01-13 18:58:05 UTC

The handbook says either is acceptable now.  I think it's a recent change, because I remember my first port being a shar.  Personally, I find patches much easier to work with.