Bug 215514 - [NEW PORT] devel/pecl-weakref2
Summary: [NEW PORT] devel/pecl-weakref2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-23 14:15 UTC by Jochen Neumeister
Modified: 2017-05-06 04:00 UTC (History)
3 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2016-12-23 14:15 UTC, Jochen Neumeister 		joneum: maintainer-approval-
Details | Diff
Patch (2.50 KB, patch)
2017-03-17 18:01 UTC, Jochen Neumeister 		joneum: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jochen Neumeister freebsd_committer freebsd_triage 2016-12-23 14:15:48 UTC 
Created attachment 178222 [details]
Patch

devel/pecl-weakref was updating to version 0.3.3

The Port build only with PHP Version 7 or newer: https://pecl.php.net/package/Weakref

I'm not sure if this should be mentioned in UPDATING.

Commiter: pls give me a feedback for me text in UPDATING - my english is very bad.

Poudriere build fine for:
9.3 amd + i386
10.3 amd + i386
11.0 amd + i386
12-current amd + i386 (r307551)

portlint is also fine.

Make test is fine, too.

Cheers
jochen
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2016-12-23 15:49:55 UTC 
Hi.

I think you should keep 0.2.6 for PHP Version 5.6 and create a new port for 0.3.3 with IGNORE_WITH_PHP = 56

See math/pecl-stats and math/pecl-stats2 for instance, but there are other pecl doing the same.
Comment 2 Jochen Neumeister freebsd_committer freebsd_triage 2016-12-24 06:43:58 UTC 
(In reply to Danilo G. Baio (dbaio) from comment #1)

I think, this is the best way. Tanks for the hint. So i will do this ;)
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-17 18:01:07 UTC 
Created attachment 180908 [details]
Patch

This port is a copy from devel/pecl-weakref, and use PHP7
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-03-18 16:48:44 UTC 
Please consider different naming. The suffix "2" seems to be incorrect.
Comment 6 Jochen Neumeister freebsd_committer freebsd_triage 2017-03-19 19:30:39 UTC 
(In reply to Po-Chuan Hsieh from comment #5)

a lot of me Ports use this suffix:

pear-HTML_QuickForm
pear-HTML_QuickForm2

pear-PEAR_PackageFileManager
pear-PEAR_PackageFileManager2

pear-channel-symfony
pear-channel-symfony2

thx
Comment 7 Jochen Neumeister freebsd_committer freebsd_triage 2017-05-02 16:14:15 UTC 
ping @miwi
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-05-06 04:00:38 UTC 
A commit references this bug:

Author: miwi
Date: Sat May  6 04:00:17 UTC 2017
New revision: 440213
URL: https://svnweb.freebsd.org/changeset/ports/440213

Log:
  - Repocopy from devel/pecl-weakref -> devel/pecl-weakref2
  - Update to 0.3.3 for php7 support

  PR:		215514
  Submitted by:	maintainer

Changes:
  head/devel/Makefile
  head/devel/pecl-weakref2/
  head/devel/pecl-weakref2/Makefile
  head/devel/pecl-weakref2/distinfo