Bug 215521 - audio/aucatctl: Fix setting master volume on i386
Summary: audio/aucatctl: Fix setting master volume on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL: https://pkg.tobik.me/logs/audio___auc...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-12-23 16:45 UTC by Tobias Kortkamp
Modified: 2016-12-25 09:33 UTC (History)
1 user (show)

See Also:

Attachments
aucatctl.diff (775 bytes, patch)
2016-12-23 16:45 UTC, Tobias Kortkamp 		tobik: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-12-23 16:45:24 UTC 
Created attachment 178232 [details]
aucatctl.diff

When setting the master volume aucatctl leaves a field uninitialized leading to potentially sending a garbage sysex message to sndio i.e. the master volume remains unchanged.  This bug seems to not happen on amd64, but does happen on i386 and armv6.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-12-24 10:27:30 UTC 
A commit references this bug:

Author: ehaupt
Date: Sat Dec 24 10:27:19 UTC 2016
New revision: 429325
URL: https://svnweb.freebsd.org/changeset/ports/429325

Log:
  Fix setting master volume on i386

  PR:		215521
  Submitted by:	t@tobik.me (maintainer)
  MFH:		2016Q4

Changes:
  head/audio/aucatctl/Makefile
  head/audio/aucatctl/files/
  head/audio/aucatctl/files/patch-aucatctl.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-12-25 09:31:53 UTC 
A commit references this bug:

Author: ehaupt
Date: Sun Dec 25 09:31:34 UTC 2016
New revision: 429406
URL: https://svnweb.freebsd.org/changeset/ports/429406

Log:
  MFH: r429325

  Fix setting master volume on i386

  PR:		215521
  Submitted by:	t@tobik.me (maintainer)

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/audio/aucatctl/Makefile
  branches/2016Q4/audio/aucatctl/files/
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2016-12-25 09:33:50 UTC 
Committed, thanks!