Bug 215550 - [PATCH] devel/e2fsprogs-libss: Set BUILD_WRKSRC instead of adding a post-build target.
Summary: [PATCH] devel/e2fsprogs-libss: Set BUILD_WRKSRC instead of adding a post-buil...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Benjamin Kaduk
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-12-25 16:34 UTC by Raphael Kubo da Costa
Modified: 2016-12-25 19:19 UTC (History)
1 user (show)

See Also:
bjk: maintainer-feedback+


Attachments
Proposed patch (668 bytes, patch)
2016-12-25 16:34 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer 2016-12-25 16:34:29 UTC
Created attachment 178262 [details]
Proposed patch

The attached patch simplifies the port's Makefile a little bit by dropping the "post-build" target that actually builds libss and setting BUILD_WRKSRC instead.

I've tested the change on both 12-amd64 and 9.3-i386, and in both cases the "subst" target is built automatically before libss, so everything works as expected.
Comment 1 Benjamin Kaduk freebsd_committer 2016-12-25 18:00:42 UTC
It's not immediately clear to me just from looking at the patch what would cause the subs target to get built before libss, but you tested, so it should be fine.  Thanks for the patch; it is cleaner to have it this way!
Comment 2 Raphael Kubo da Costa freebsd_committer 2016-12-25 19:17:48 UTC
It's also a bit weird to me because of the build system, but the Makefile generated in lib/ss does include a dependency on the subst target so I think we're safe here.
Comment 3 commit-hook freebsd_committer 2016-12-25 19:19:09 UTC
A commit references this bug:

Author: rakuco
Date: Sun Dec 25 19:18:47 UTC 2016
New revision: 429452
URL: https://svnweb.freebsd.org/changeset/ports/429452

Log:
  Set BUILD_WRKSRC instead of adding a post-build target

  Simplify the port's Makefile a little bit by dropping the "post-build" target
  that actually builds libss and setting BUILD_WRKSRC instead.

  The port's build system takes care of making lib/ss depend on the subst target.

  PR:		215550
  Approved by:	bjk (maintainer)

Changes:
  head/devel/e2fsprogs-libss/Makefile