Bug 215594 - www/apache24: [PATCH] Fix build with mpm_itk
Summary: www/apache24: [PATCH] Fix build with mpm_itk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-apache mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-12-27 01:07 UTC by Marcelo Araujo
Modified: 2016-12-27 10:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (apache)
ohauer: merge-quarterly+


Attachments
Fix the -Werror problem. (2.03 KB, patch)
2016-12-27 01:07 UTC, Marcelo Araujo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcelo Araujo freebsd_committer 2016-12-27 01:07:07 UTC
Created attachment 178305 [details]
Fix the -Werror problem.

On FreeBSD I have found an issue, specially when we are building the module mpm_itk together with the newest apache version 2.4.25 that makes the build fail with an error.

the previous version:
usr/local/include/apache24/ap_config_auto.h:253:9: warning: 'PACKAGE_VERSION' macro redefined [-Wmacro-redefined]
#define PACKAGE_VERSION ""
 
 
new version 2.4.25:
In file included from /usr/local/include/apache24/ap_config.h:138:
/usr/local/include/apache24/ap_config_auto.h:257:9: error: 'PACKAGE_VERSION' macro redefined [-Werror,-Wmacro-redefined]
#define PACKAGE_VERSION ""
 
As you can see, apache package added on configure.in the option '-Werror', the macro-redefined before was just a warning but now the build fail with an error.

This patch fix the issue, basically I'm removing the -Werror.
Comment 1 commit-hook freebsd_committer 2016-12-27 09:53:21 UTC
A commit references this bug:

Author: ohauer
Date: Tue Dec 27 09:52:14 UTC 2016
New revision: 429588
URL: https://svnweb.freebsd.org/changeset/ports/429588

Log:
  - fix third party module build e.g. mod_mpm_itk by removing -Werror from configure.in
  - bump PORTREVISON (fix changes config_vars.mk that is used to build third party modules)

  PR:		215594
  Submitted by:	Marcelo Araujo
  MFH:		2016Q4
  Sponsored by:	iXsystems

Changes:
  head/www/apache24/Makefile
  head/www/apache24/files/patch-configure.in
Comment 2 Olli Hauer freebsd_committer 2016-12-27 10:05:27 UTC
Thanks for the hint with mpm_itk, your patch was committed!
Comment 3 commit-hook freebsd_committer 2016-12-27 10:31:59 UTC
A commit references this bug:

Author: ohauer
Date: Tue Dec 27 10:31:48 UTC 2016
New revision: 429597
URL: https://svnweb.freebsd.org/changeset/ports/429597

Log:
  MFH: r429588

  - fix third party module build e.g. mod_mpm_itk by removing -Werror from configure.in
  - bump PORTREVISON (fix changes config_vars.mk that is used to build third party modules)

  PR:		215594
  Submitted by:	Marcelo Araujo
  Sponsored by:	iXsystems

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2016Q4/
  branches/2016Q4/www/apache24/Makefile
  branches/2016Q4/www/apache24/files/patch-configure.in