Bug 215652 - devel/p5-Connector: update to 1.22
Summary: devel/p5-Connector: update to 1.22
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-29 14:14 UTC by Sergei Vyshenski
Modified: 2016-12-29 17:36 UTC (History)
1 user (show)

See Also:

Attachments
patch to update the port (1.80 KB, patch)
2016-12-29 14:14 UTC, Sergei Vyshenski 		svysh.fbsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2016-12-29 14:14:10 UTC 
Created attachment 178377 [details]
patch to update the port

devel/p5-Connector: update to 1.22
- Update 1.21 --> 1.22
Changes: https://github.com/mrscotty/connector/commits/master

- "portlint -AC" gives just non-relevant warnings.

- Tested OK at 11.stable-amd64 
with poudriere-3.1.14, perl-5.24.1, and openssl from base.

- "make test" says PASS.
Comment 1 Sunpoet Po-Chuan Hsieh freebsd_committer 2016-12-29 15:00:06 UTC 
I've checked the newly-added dependencies, I think it should be:

@@ -16,7 +16,10 @@
 BUILD_DEPENDS= bash:shells/bash \
                p5-AppConfig>=0:devel/p5-AppConfig \
                p5-Config-GitLike>=0:devel/p5-Config-GitLike \
+               p5-Config-Merge>=0:devel/p5-Config-Merge \
                p5-Config-Versioned>=1.01:devel/p5-Config-Versioned \
+               p5-Crypt-SSLeay>=0:security/p5-Crypt-SSLeay \
+               p5-DBI>=0:databases/p5-DBI \
                p5-Log-Log4perl>=0:devel/p5-Log-Log4perl \
                p5-Module-Install>=0:devel/p5-Module-Install \
                p5-Moose>=0:devel/p5-Moose \
@@ -24,8 +27,10 @@
                p5-Template-Toolkit>=0:www/p5-Template-Toolkit \
                p5-Text-CSV_XS>=0:textproc/p5-Text-CSV_XS \
                p5-YAML>=1.06:textproc/p5-YAML \
+               p5-libwww>=0:www/p5-libwww \
                p5-perl-ldap>=0:net/p5-perl-ldap
 RUN_DEPENDS:=  ${BUILD_DEPENDS}
+TEST_DEPENDS=  p5-DBD-SQLite>=0:databases/p5-DBD-SQLite

 USES=          perl5
 USE_PERL5=     configure
Comment 2 Sergei Vyshenski 2016-12-29 15:24:12 UTC 
During build stage, it complains about missing DBD::SQLite, if you do not list it inside BUILD_DEPENDS.
Comment 3 Sunpoet Po-Chuan Hsieh freebsd_committer 2016-12-29 15:27:41 UTC 
from Makefile.PL:

test_requires 'DBD::SQLite';

And it is used in t/10-proxy-dbi.t only.
Comment 4 Sergei Vyshenski 2016-12-29 15:34:23 UTC 
You are correct.
Comment 5 commit-hook freebsd_committer 2016-12-29 17:35:41 UTC 
A commit references this bug:

Author: sunpoet
Date: Thu Dec 29 17:35:05 UTC 2016
New revision: 429930
URL: https://svnweb.freebsd.org/changeset/ports/429930

Log:
  - Update to 1.22

  Changes:	https://github.com/mrscotty/connector/commits/master
  PR:		215652
  Submitted by:	Sergei Vyshenski <svysh.fbsd@gmail.com> (maintainer)

Changes:
  head/devel/p5-Connector/Makefile
  head/devel/p5-Connector/distinfo
Comment 6 Sunpoet Po-Chuan Hsieh freebsd_committer 2016-12-29 17:36:03 UTC 
Committed. Thanks!