Bug 215685 - databases/p5-SQL-Abstract: fix dependencies
Summary: databases/p5-SQL-Abstract: fix dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-31 15:58 UTC by Sergei Vyshenski
Modified: 2017-01-01 02:00 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (perl)


Attachments
patch for updating the port (1005 bytes, patch)
2016-12-31 15:58 UTC, Sergei Vyshenski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2016-12-31 15:58:48 UTC
Created attachment 178418 [details]
patch for updating the port

- move devel/p5-Moo from TEST_DEPENDS to BUILD_DEPENDS.
It is explicitly used to build module Tree.pm.
And Makefile.PL says: requires 'Moo' => '1.004002';

- MRO::Compat required by Makefile.PL is not actually used.

- add NO_ARCH=yes

- "portlint -AC" gives just non-relevant warnings.

- Tested (with and without buil-in perl tests) at 11.stable-amd64 
with poudriere-3.1.14, perl-5.24.1, and openssl from base.
To activate test from within poudriere, file  
Mk/Uses/perl5.mk was locally augmented with lines:

.if defined(RUN_PERL_TESTS)
BUILD_DEPENDS+= ${TEST_DEPENDS}
pre-install:    test
.endif

All tests say: PASS.
Comment 1 commit-hook freebsd_committer 2017-01-01 01:48:16 UTC
A commit references this bug:

Author: sunpoet
Date: Sun Jan  1 01:47:35 UTC 2017
New revision: 430228
URL: https://svnweb.freebsd.org/changeset/ports/430228

Log:
  Fix *_DEPENDS

  - Move p5-Moo from TEST_DEPENDS to {BUILD|RUN}_DEPENDS
  - Bump PORTREVISION for dependency change
  - While I'm here, add NO_ARCH

  PR:		215685
  Submitted by:	Sergei Vyshenski <svysh.fbsd@gmail.com>

Changes:
  head/databases/p5-SQL-Abstract/Makefile
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2017-01-01 02:00:37 UTC
Committed. Thanks!