Bug 215720 - textproc/libcsv: Submit patches and claim maintainership
Summary: textproc/libcsv: Submit patches and claim maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-03 00:22 UTC by Bob Eager
Modified: 2017-01-03 12:28 UTC (History)
1 user (show)

See Also:

Attachments
Patches to files in port directory (9.10 KB, patch)
2017-01-03 00:22 UTC, Bob Eager 		no flags Details | Diff
Use options helpers (9.20 KB, patch)
2017-01-03 09:14 UTC, Matthew Seaman 		matthew: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Eager 2017-01-03 00:22:08 UTC 
Created attachment 178463 [details]
Patches to files in port directory

Claiming maintainership for this port, as bob@eager.cx.

Patches included, bumping PORTREVISION:
- fix missing prototypes in csv.h
- fix typos and errors in csv.3
- add missing but documented function csv_get_blk_size
- add EXAMPLES option and provide examples if required

New files:
files/patch-csv.3
files/patch-csv.h
files/patch-libcsv.c
Comment 1 Matthew Seaman freebsd_committer freebsd_triage 2017-01-03 09:14:04 UTC 
Created attachment 178465 [details]
Use options helpers

Hi,

What do you think of this update to your patch?  It just adds the use of options helpers.
Comment 2 Bob Eager 2017-01-03 09:47:15 UTC 
Comment on attachment 178465 [details]
Use options helpers

No problem. Go ahead.

(that was partly original stuff that I hadn't touched, but would have done later)
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-01-03 12:28:35 UTC 
A commit references this bug:

Author: matthew
Date: Tue Jan  3 12:27:56 UTC 2017
New revision: 430461
URL: https://svnweb.freebsd.org/changeset/ports/430461

Log:
  New maintainer: bob@eager.cx

  Add new 'EXAMPLES' option
  Use OPTIONS helpers
  Spelling fixes for man pages
  Add a csv_get_blk_size() function

  PR:		215720
  Submitted by:	bob@eager.cx

Changes:
  head/textproc/libcsv/Makefile
  head/textproc/libcsv/files/patch-csv.3
  head/textproc/libcsv/files/patch-csv.h
  head/textproc/libcsv/files/patch-libcsv.c
  head/textproc/libcsv/pkg-plist
Comment 4 Matthew Seaman freebsd_committer freebsd_triage 2017-01-03 12:28:56 UTC 
Committed, thanks!