Bug 215734 - security/openvpn-devel: Update to 2016-52
Summary: security/openvpn-devel: Update to 2016-52
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-03 14:48 UTC by Eric F Crist
Modified: 2017-01-04 14:43 UTC (History)
2 users (show)

See Also:
mandree: maintainer-feedback+


Attachments
gzipped tarball of new files and Makefile (9.34 KB, application/x-compressed-tar)
2017-01-03 14:48 UTC, Eric F Crist
no flags Details
updated tarball (9.33 KB, application/x-compressed-tar)
2017-01-04 13:34 UTC, Eric F Crist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eric F Crist 2017-01-03 14:48:32 UTC
Created attachment 178479 [details]
gzipped tarball of new files and Makefile

This update aligns the Makefile with the release port for OpenVPN, bringing along the RC scripts and Tunnelblick patches.  Also, this updates the port to the 2016 week 52 development snapshot.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2017-01-03 22:43:58 UTC
Eric, 

1. the new port removes warning messages about the developer version from pkg-message.in - is that what you want?

2. the plist seems to be incorrect ("make stage check-plist"):
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: libexec/openvpn-client.down
Error: Orphaned: libexec/openvpn-client.up
Error: Orphaned: sbin/openvpn-client

Please investigate and follow up with a new tarball.
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2017-01-03 22:52:05 UTC
Oh, and pkg-help doesn't appear to be part of your tarball, while you have the TUNNELBLICK option that is described as "READ HELP".
Comment 3 Eric F Crist 2017-01-04 13:34:19 UTC
Since the Tunnelblick XOR patch was applied in 2.4, I've removed it.  I copied the Makefile out of your main security/openvpn port, which is also missing the pkg-help file.

I've attached a new tarball that should have the remaining comments resolved.
Comment 4 Eric F Crist 2017-01-04 13:34:53 UTC
Created attachment 178507 [details]
updated tarball
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2017-01-04 14:38:41 UTC
(In reply to ecrist from comment #3)
I beg to differ on the "your main security/openvpn port, which is also missing the pkg-help file" part: <https://svnweb.freebsd.org/ports/head/security/openvpn/>.
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-01-04 14:39:10 UTC
A commit references this bug:

Author: mandree
Date: Wed Jan  4 14:39:01 UTC 2017
New revision: 430558
URL: https://svnweb.freebsd.org/changeset/ports/430558

Log:
  Update openvpn-devel to 2016-52 snapshot.

  Align with security/openvpn for RC script improvements, dropping the
  TUNNELBLICK patch (integrated upstream) and pkg-help file (no longer
  required).

  Note that pkcs11* and mbedTLS currently do not mix (I randomly checked
  different option sets), an issue this port shares with security/openvpn.
  "checking mbedtls pkcs11 support...
  configure: error: mbedtls has no pkcs11 wrapper compiled in"

  PR:		215734
  Submitted by:	Eric F. Crist (maintainer)

Changes:
  head/security/openvpn-devel/Makefile
  head/security/openvpn-devel/distinfo
  head/security/openvpn-devel/files/extra-tunnelblick-openvpn_xorpatch
  head/security/openvpn-devel/files/openvpn-client.in
  head/security/openvpn-devel/files/openvpn.in
  head/security/openvpn-devel/files/patch-configure
  head/security/openvpn-devel/files/patch-sample__sample-config-files__loopback-client
  head/security/openvpn-devel/files/patch-sample__sample-config-files__loopback-server
  head/security/openvpn-devel/files/patch-tests__t_cltsrv.sh
  head/security/openvpn-devel/files/pkg-message.in
  head/security/openvpn-devel/files/up-script.sample
  head/security/openvpn-devel/pkg-plist
Comment 7 Matthias Andree freebsd_committer freebsd_triage 2017-01-04 14:43:21 UTC
I have asked tijl@ (the security/mbedtls maintainer) for his opinion on PKCS#11 support in mbedtls by separate e-mail.