Bug 215759 - Add PHP 7.1 framework
Summary: Add PHP 7.1 framework
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-04 10:55 UTC by Torsten Zuehlsdorff
Modified: 2017-01-31 14:35 UTC (History)
2 users (show)

See Also:

Attachments
MK changes for PHP 7.1 introduction (1.68 KB, patch)
2017-01-04 10:55 UTC, Torsten Zuehlsdorff 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-01-04 10:55:07 UTC 
Created attachment 178500 [details]
MK changes for PHP 7.1 introduction

Hello,

in preparation of adding PHP 7.1 to the ports-tree some changes to the framework code are needed.

There is also a Review for the full patch:
https://reviews.freebsd.org/D8693
But sadly the review Tool just didn't work correctly for me. It did not update the patch correctly and fails on every Umlaut. Therefore i ripped out the Mk/ changes and put them into this PR.

Greetings,
Torsten
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2017-01-04 11:47:32 UTC 
Mmmm, if the aim is to ask for an exp-run, please submit the full patch.
Comment 2 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-01-04 12:07:41 UTC 
> Mmmm, if the aim is to ask for an exp-run, please submit the full patch.

Sorry, i should have make myself more clear:

The aim is to get approval (or somebody doing it) to commit this needed part of the patch to Mk/. After that i can commit this rest of the patch (or all in once)

As far as i understood the policy changes to Mk/ need approval of portmgr@, or am i wrong?
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2017-01-04 12:30:34 UTC 
Most files in Mk have MAINTAINER defined somewhere, you have to get approval from them.
For bsd.default-versions.mk, ports@ so no approval.
For Uses/php.mk, it is supposed to be ale.

What portmgr wants to have a looksie at, and possibly run tests is infrastructure changes, to make sure it works, but even if we sometime rewrite everything, we don't maintain all of it :-)
Comment 4 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-01-31 14:35:11 UTC 
Changes were already done and PHP 7.1 moved into the ports-tree :)