Bug 215794 - x11/xfce4-terminal preferences panel doesn't work
Summary: x11/xfce4-terminal preferences panel doesn't work
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-05 10:00 UTC by Yuichiro NAITO
Modified: 2017-01-06 08:11 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (xfce)


Attachments
Screenshot of xfce4-terminal preferences panel (11.37 KB, image/png)
2017-01-05 10:00 UTC, Yuichiro NAITO
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuichiro NAITO 2017-01-05 10:00:03 UTC
Created attachment 178540 [details]
Screenshot of xfce4-terminal preferences panel

I upgraded my xfce4 environment by "pkg upgrade".
It includes xfce4-terminal is upgraded from 0.6.3_2 to 0.8.2,
After "pkg upgrade",
xfce4-terminal preferences panel doesn't work.

Attached file is the screen shot.
Comment 1 Olivier Duchateau freebsd_committer 2017-01-05 10:17:21 UTC
Could you show error/warning message when you launch xfce4-terminal in other terminal emulator (e.g. xterm)?
Comment 2 Yuichiro NAITO 2017-01-05 12:25:03 UTC
I could see the message on my xterm.

% xfce4-terminal
(xfce4-terminal:1314): xfce4-terminal-CRITICAL **: Failed to load ui file: /usr/local/share/xfce4/terminal/terminal-preferences.ui:5:25272 Invalid property: GtkColorButton.show_editor.
Comment 3 commit-hook freebsd_committer 2017-01-05 13:14:23 UTC
A commit references this bug:

Author: olivierd
Date: Thu Jan  5 13:13:35 UTC 2017
New revision: 430635
URL: https://svnweb.freebsd.org/changeset/ports/430635

Log:
  - Add patch, which removes 'show_editor' property (available in Gtk+
    since 3.20) in GtkColorButton, otherwise Preferences dialog
    is empty
  - Bump PORTREVISION

  PR:		215794
  Reported by:	<naito.yuichiro@gmail.com>
  MFH:		2017Q1

Changes:
  head/x11/xfce4-terminal/Makefile
  head/x11/xfce4-terminal/files/patch-terminal_terminal-preferences.ui
Comment 4 Olivier Duchateau freebsd_committer 2017-01-05 13:23:33 UTC
I committed a workaround in HEAD.

If you are using quaterly branch, it'll be propagated when someone in ports management team (portmgr) will approve my changes.

Thanks!
Comment 5 Yuichiro NAITO 2017-01-06 01:12:15 UTC
I built and re-installed xfce4-terminal from ports.
Your patch fixed this problem.
Thank you!
Comment 6 commit-hook freebsd_committer 2017-01-06 08:11:49 UTC
A commit references this bug:

Author: olivierd
Date: Fri Jan  6 08:11:30 UTC 2017
New revision: 430691
URL: https://svnweb.freebsd.org/changeset/ports/430691

Log:
  MFH: r430635

  - Add patch, which removes 'show_editor' property (available in Gtk+
    since 3.20) in GtkColorButton, otherwise Preferences dialog
    is empty
  - Bump PORTREVISION

  PR:		215794
  Reported by:	<naito.yuichiro@gmail.com>

  Approved by:	ports-secteam (junovitch@)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/x11/xfce4-terminal/Makefile
  branches/2017Q1/x11/xfce4-terminal/files/patch-terminal_terminal-preferences.ui