Bug 215815 - [PATCH] multimedia/plexhometheater: un-BREAK
Summary: [PATCH] multimedia/plexhometheater: un-BREAK
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-01-06 01:51 UTC by Kalten
Modified: 2017-11-12 15:49 UTC (History)
2 users (show)

See Also:
rene: maintainer-feedback?


Attachments
unbreak by const_cast (1.01 KB, patch)
2017-01-06 01:51 UTC, Kalten
no flags Details | Diff
modernize / try to fix plexhometheater (2.46 KB, patch)
2017-08-26 11:40 UTC, Rene Ladan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalten 2017-01-06 01:51:35 UTC
Created attachment 178567 [details]
unbreak by const_cast

Currently this port is marked broken with the description:
“Fails to build against libsamplerate-0.1.9”.

When I deleted the “BROKEN=” line, the following Error came up:
> /wrkdirs/usr/ports/multimedia/plexhometheater/work/plex-home-theater-public-1.4.1.469-47a90f01/xbmc/cores/dvdplayer/DVDPlayerAudioResampler.cpp:77:12: error: cannot initialize a variable of type 'float *' with an lvalue of type 'const float *'
>   float*   outputptr = m_converterdata.data_in;
>            ^           ~~~~~~~~~~~~~~~~~~~~~~~

I do not understand the BROKEN-message compared to the compiler-error.

I did cast to float*—analogous to other code there, although using
const_cast—as this seems what is intended (see attachment) and now it does
compile and seems to work.
The original authors should be told about it, I presume.

Am I missing something?

Regards,
 Kalten
Comment 1 Kalten 2017-02-14 16:38:48 UTC
No reaction since more than one month and one week :-(
Pray do answer!

Regards,
 Kalten
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2017-08-23 11:25:15 UTC
Taking over, rescue port from expiration.
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2017-08-26 11:40:30 UTC
Created attachment 185779 [details]
modernize / try to fix plexhometheater
Comment 4 Rene Ladan freebsd_committer freebsd_triage 2017-11-12 15:49:50 UTC
Removing this port. The maintainer does not respond, it needs at least two other compilations fixes, has several known vulnerabilities in its bundled ffmpeg, and has not been updated upstream since 2.5 years.