Bug 215959 - [patch] sysutils/htop does not need python to build
Summary: [patch] sysutils/htop does not need python to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Adam Weinberger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-01-11 06:51 UTC by Adam Weinberger
Modified: 2017-01-11 14:16 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gaod)


Attachments
Remove python dependency (475 bytes, patch)
2017-01-11 06:51 UTC, Adam Weinberger
no flags Details | Diff
Build log (48.62 KB, text/plain)
2017-01-11 06:52 UTC, Adam Weinberger
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer 2017-01-11 06:51:44 UTC
Created attachment 178740 [details]
Remove python dependency

htop doesn't seem to need python at all to build. Please see the attached log.

AFAICT we can just remove the python dependency entirely (as well as the shebangfix).
Comment 1 Adam Weinberger freebsd_committer 2017-01-11 06:52:32 UTC
Created attachment 178741 [details]
Build log

Build log showing successful build without python.
Comment 2 Hung-Yi Chen 2017-01-11 08:01:54 UTC
Hi Adam,

You are right.

There is no need to invoke python.

The patch seems fine, please commit it, thanks.
Comment 3 commit-hook freebsd_committer 2017-01-11 14:15:27 UTC
A commit references this bug:

Author: adamw
Date: Wed Jan 11 14:14:55 UTC 2017
New revision: 431183
URL: https://svnweb.freebsd.org/changeset/ports/431183

Log:
  Python is never actually used in the build here, so remove the dependency
  and the associated shebangfix.

  PR:		215959
  Approved by:	maintainer (Hung-Yi Chen)

Changes:
  head/sysutils/htop/Makefile
Comment 4 Adam Weinberger freebsd_committer 2017-01-11 14:16:20 UTC
Done. Thanks for reviewing so quickly!