Bug 216058 - multimedia/vdr: fails to build with clang 4.0
Summary: multimedia/vdr: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-14 06:45 UTC by Jan Beich
Modified: 2017-02-01 12:56 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-14 06:45:43 UTC 
recording.c:2090:17: error: ordered comparison between pointer and zero ('cUnbufferedFile *' and 'int')
     if (Open() >= 0) {
         ~~~~~~ ^  ~

build log: http://sprunge.us/OaXb
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-01 05:26:00 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:24:48 UTC 2017
New revision: 432967
URL: https://svnweb.freebsd.org/changeset/ports/432967

Log:
  multimedia/vdr: unbreak with clang 4.0

  recording.c:2090:17: error: ordered comparison between pointer and zero ('cUnbufferedFile *' and 'int')
       if (Open() >= 0) {
           ~~~~~~ ^  ~

  PR:		216058
  Reported by:	antoine (via exp-run)

Changes:
  head/multimedia/vdr/Makefile
  head/multimedia/vdr/files/patch-clang40
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-02-01 12:56:21 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 12:56:04 UTC 2017
New revision: 433027
URL: https://svnweb.freebsd.org/changeset/ports/433027

Log:
  MFH: r432967

  multimedia/vdr: unbreak with clang 4.0

  recording.c:2090:17: error: ordered comparison between pointer and zero ('cUnbufferedFile *' and 'int')
       if (Open() >= 0) {
           ~~~~~~ ^  ~

  PR:		216058
  Reported by:	antoine (via exp-run)
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q1/
  branches/2017Q1/multimedia/vdr/Makefile
  branches/2017Q1/multimedia/vdr/files/patch-clang40