Bug 216072 - games/vegastrike: fails to build with clang 4.0
Summary: games/vegastrike: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-14 15:55 UTC by Jan Beich
Modified: 2017-02-01 05:29 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-14 15:55:18 UTC
games/vegastrike: fails to build with clang 4.0

setup/src/include/central.cpp:37:37: error: ordered comparison between pointer and zero ('struct group *' and 'int')
        } while ((CURRENT = CURRENT->next) > 0);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:45:37: error: ordered comparison between pointer and zero ('struct catagory *' and 'int')
        } while ((CURRENT = CURRENT->next) > 0);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:57:37: error: ordered comparison between pointer and zero ('struct catagory *' and 'int')
        } while ((CURRENT = CURRENT->next) > 0);
                 ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:67:29: error: ordered comparison between pointer and zero ('struct group *' and 'int')
        } while ((CUR = CUR->next) > 0);
                 ~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:77:29: error: ordered comparison between pointer and zero ('struct catagory *' and 'int')
        } while ((CUR = CUR->next) > 0);
                 ~~~~~~~~~~~~~~~~~ ^ ~
setup/src/include/central.cpp:87:36: error: ordered comparison between pointer and zero ('struct group *' and 'int')
        } while ((CUR = CUR->next) > 0);
                 ~~~~~~~~~~~~~~~~~ ^ ~

build log: http://sprunge.us/iBLO
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer 2017-02-01 05:27:10 UTC
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:25:55 UTC 2017
New revision: 432972
URL: https://svnweb.freebsd.org/changeset/ports/432972

Log:
  games/vegastrike: unbreak with clang 4.0

  setup/src/include/central.cpp:37:37: error: ordered comparison between pointer and zero
        ('struct group *' and 'int')
          } while ((CURRENT = CURRENT->next) > 0);
                   ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:45:37: error: ordered comparison between pointer and zero
        ('struct catagory *' and 'int')
          } while ((CURRENT = CURRENT->next) > 0);
                   ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:57:37: error: ordered comparison between pointer and zero
        ('struct catagory *' and 'int')
          } while ((CURRENT = CURRENT->next) > 0);
                   ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:67:29: error: ordered comparison between pointer and zero
        ('struct group *' and 'int')
          } while ((CUR = CUR->next) > 0);
                   ~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:77:29: error: ordered comparison between pointer and zero
        ('struct catagory *' and 'int')
          } while ((CUR = CUR->next) > 0);
                   ~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/central.cpp:87:36: error: ordered comparison between pointer and zero
        ('struct group *' and 'int')
          } while ((CUR = CUR->next) > 0);
                   ~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/display_gtk.cpp:112:36: error: ordered comparison between pointer and zero
        ('catagory *' and 'int')
                  } while ((NEWCUR = NEWCUR->next) > 0);
                           ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/display_gtk.cpp:127:37: error: ordered comparison between pointer and zero
        ('struct group *' and 'int')
          } while ((CURRENT = CURRENT->next) > 0);
                   ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/display_gtk.cpp:183:29: error: ordered comparison between pointer and zero
        ('struct catagory *' and 'int')
          } while ((CUR = CUR->next) > 0);
                   ~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/file.cpp:170:52: error: ordered comparison between pointer and zero
        ('char *' and 'int')
              while ( ( n_parm = next_parm( parm ) ) > 0 ) {
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/file.cpp:191:52: error: ordered comparison between pointer and zero
        ('char *' and 'int')
              while ( ( n_parm = next_parm( parm ) ) > 0 ) {
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/file.cpp:321:52: error: ordered comparison between pointer and zero
        ('char *' and 'int')
              while ( ( n_parm = next_parm( parm ) ) > 0 ) {
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  setup/src/include/general.cpp:124:46: error: ordered comparison between pointer and zero
        ('char *' and 'int')
          while ((location = strstr(current, search)) > 0) {
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

  PR:		216072
  Reported by:	antoine (via exp-run)

Changes:
  head/games/vegastrike/files/patch-clang40